go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
gvisor/Makefile

499 lines
20 KiB
Makefile
Raw Normal View History

Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
#!/usr/bin/make -f
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
# Copyright 2019 The gVisor Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
arm64: add a travis build ci Build runsc and run "runsc do ls". Signed-off-by: Andrei Vagin <avagin@gmail.com>
2019-11-12 04:26:38 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
default: runsc
.PHONY: default
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
# Header for debugging (used by other macros).
header = echo --- $(1) >&2
# Make hacks.
EMPTY :=
SPACE := $(EMPTY) $(EMPTY)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
SHELL = /bin/bash
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
## usage: make <target>
## or
make: Allow to specify bazel startup options. And don't parse binary paths for the build target. Signed-off-by: Andrei Vagin <avagin@gmail.com>
2020-06-02 18:30:26 +00:00
## make <build|test|copy|run|sudo> STARTUP_OPTIONS="..." OPTIONS="..." TARGETS="..." ARGS="..."
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
##
## Basic targets.
##
## This Makefile wraps basic build and test targets for ease-of-use. Bazel
## is run inside a canonical Docker container in order to simplify up-front
## requirements.
##
## There are common arguments that may be passed to targets. These are:
## OPTIONS - Build or test options.
## TARGETS - The bazel targets.
## ARGS - Arguments for run or sudo.
##
## Additionally, the copy target expects a DESTINATION to be provided.
##
## For example, to build runsc using this Makefile, you can run:
## make build OPTIONS="" TARGETS="//runsc"'
##
help: ## Shows all targets and help from the Makefile (this message).
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@grep --no-filename -E '^([a-z.A-Z_%-]+:.*?|)##' $(MAKEFILE_LIST) | \
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
awk 'BEGIN {FS = "(:.*?|)## ?"}; { \
if (length($$1) > 0) { \
printf " \033[36m%-20s\033[0m %s\n", $$1, $$2; \
} else { \
printf "%s\n", $$2; \
} \
}'
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
build: ## Builds the given $(TARGETS) with the given $(OPTIONS). E.g. make build TARGETS=runsc
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call build,$(OPTIONS) $(TARGETS))
.PHONY: build
test: ## Tests the given $(TARGETS) with the given $(OPTIONS). E.g. make test TARGETS=pkg/buffer:buffer_test
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call test,$(OPTIONS) $(TARGETS))
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
.PHONY: test
copy: ## Copies the given $(TARGETS) to the given $(DESTINATION). E.g. make copy TARGETS=runsc DESTINATION=/tmp
@$(call copy,$(TARGETS),$(DESTINATION))
.PHONY: copy
run: ## Runs the given $(TARGETS), built with $(OPTIONS), using $(ARGS). E.g. make run TARGETS=runsc ARGS=-version
Fix run and sudo targets. These are not passing arguments properly. This breaks the current pre-command for BuildKite. PiperOrigin-RevId: 347062729
2020-12-11 21:23:27 +00:00
@$(call run,$(TARGETS),$(ARGS))
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
.PHONY: run
sudo: ## Runs the given $(TARGETS) as per run, but using "sudo -E". E.g. make sudo TARGETS=test/root:root_test ARGS=-test.v
Fix run and sudo targets. These are not passing arguments properly. This breaks the current pre-command for BuildKite. PiperOrigin-RevId: 347062729
2020-12-11 21:23:27 +00:00
@$(call sudo,$(TARGETS),$(ARGS))
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
.PHONY: sudo
# Load image helpers.
include tools/images.mk
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
# Load all bazel wrappers.
#
# This file should define the basic "build", "test", "run" and "sudo" rules, in
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
# addition to the $(BRANCH_NAME) and $(BUILD_ROOTS) variables.
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
ifneq (,$(wildcard tools/google.mk))
include tools/google.mk
else
include tools/bazel.mk
endif
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
##
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
## Development helpers and tooling.
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
##
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
## These targets faciliate local development by automatically
## installing and configuring a runtime. Several variables may
## be used here to tweak the installation:
## RUNTIME - The name of the installed runtime (default: branch).
## RUNTIME_DIR - Where the runtime will be installed (default: temporary directory with the $RUNTIME).
## RUNTIME_BIN - The runtime binary (default: $RUNTIME_DIR/runsc).
## RUNTIME_LOG_DIR - The logs directory (default: $RUNTIME_DIR/logs).
## RUNTIME_LOGS - The log pattern (default: $RUNTIME_LOG_DIR/runsc.log.%TEST%.%TIMESTAMP%.%COMMAND%).
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
## RUNTIME_ARGS - Arguments passed to the runtime when installed.
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
## STAGED_BINARIES - A tarball of staged binaries. If this is set, then binaries
## will be installed from this staged bundle instead of built.
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
##
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
ifeq (,$(BRANCH_NAME))
RUNTIME := runsc
RUNTIME_DIR := $(shell dirname $(shell mktemp -u))/$(RUNTIME)
else
RUNTIME := $(BRANCH_NAME)
RUNTIME_DIR := $(shell dirname $(shell mktemp -u))/$(RUNTIME)
endif
RUNTIME_BIN := $(RUNTIME_DIR)/runsc
RUNTIME_LOG_DIR := $(RUNTIME_DIR)/logs
RUNTIME_LOGS := $(RUNTIME_LOG_DIR)/runsc.log.%TEST%.%TIMESTAMP%.%COMMAND%
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
RUNTIME_ARGS ?=
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
cgroupv2: skip tests on containerd < 1.4 containerd < 1.4 does not support cgroupv2, so we adjust the Make targets and installer scripts to skip test run on those versions. Signed-off-by: Daniel Dao <dqminh89@gmail.com>
2021-02-04 13:53:48 +00:00
ifeq ($(shell stat -f -c "%T" /sys/fs/cgroup 2>/dev/null),cgroup2fs)
CGROUPV2 := true
else
CGROUPV2 := false
endif
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
$(RUNTIME_BIN): # See below.
@mkdir -p "$(RUNTIME_DIR)"
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
ifeq (,$(STAGED_BINARIES))
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call copy,//runsc,$(RUNTIME_BIN))
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
else
gsutil cat "${STAGED_BINARIES}" | \
tar -C "$(RUNTIME_DIR)" -zxvf - runsc && \
chmod a+rx "$(RUNTIME_BIN)"
endif
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
.PHONY: $(RUNTIME_BIN) # Real file, but force rebuild.
# Configure helpers for below.
configure_noreload = \
$(call header,CONFIGURE $(1) → $(RUNTIME_BIN) $(2)); \
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
sudo $(RUNTIME_BIN) install --experimental=true --runtime="$(1)" -- $(RUNTIME_ARGS) --debug-log "$(RUNTIME_LOGS)" $(2) && \
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
sudo rm -rf "$(RUNTIME_LOG_DIR)" && mkdir -p "$(RUNTIME_LOG_DIR)"
reload_docker = \
sudo systemctl reload docker && \
if test -f /etc/docker/daemon.json; then \
sudo chmod 0755 /etc/docker && \
sudo chmod 0644 /etc/docker/daemon.json; \
fi
configure = $(call configure_noreload,$(1),$(2)) && $(reload_docker)
# Helpers for above. Requires $(RUNTIME_BIN) dependency.
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
install_runtime = $(call configure,$(1),$(2) --TESTONLY-test-name-env=RUNSC_TEST_NAME)
Set --nocache_test_results to runtime tests If not set, the cached result is used even when runtime options are changed, because they are not visible to blaze/bazel. PiperOrigin-RevId: 348074339
2020-12-17 20:40:26 +00:00
# Don't use cached results, otherwise multiple runs using different runtimes
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
# may be skipped, if all other inputs are the same.
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
test_runtime = $(call test,--test_env=RUNTIME=$(1) --nocache_test_results $(PARTITIONS) $(2))
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
Restore refresh target. PiperOrigin-RevId: 347864621
2020-12-16 19:42:58 +00:00
refresh: $(RUNTIME_BIN) ## Updates the runtime binary.
.PHONY: refresh
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
dev: $(RUNTIME_BIN) ## Installs a set of local runtimes. Requires sudo.
@$(call configure_noreload,$(RUNTIME),--net-raw)
@$(call configure_noreload,$(RUNTIME)-d,--net-raw --debug --strace --log-packets)
@$(call configure_noreload,$(RUNTIME)-p,--net-raw --profile)
Remove VFS2 test dimension The default is VFS2 enabled, so the tests setting VFS2 are redundant. Updates #1624 PiperOrigin-RevId: 431827013
2022-03-02 02:57:15 +00:00
@$(call configure_noreload,$(RUNTIME)-fuse-d,--net-raw --debug --strace --log-packets --fuse)
@$(call configure_noreload,$(RUNTIME)-cgroup-d,--net-raw --debug --strace --log-packets --cgroupfs)
Enable all tests for lisafs. - Generates a lisafs variant of all syscall tests. - Adds Makefile targets to run runtime tests with lisafs. We run runtime tests continuously (on every commit to master) and on presubmits iff the commit message contains "lisafs". - Updates the docker tests target to run the integration tests with lisafs too. Fixes #5466 PiperOrigin-RevId: 433782954
2022-03-10 18:06:43 +00:00
@$(call configure_noreload,$(RUNTIME)-lisafs-d,--net-raw --debug --strace --log-packets --lisafs)
Add systemd-cgroup support to runsc. This change adds systemd-cgroup support to cgroupv2 and modifies existing cgroup tests for systemd support. Fixes #193 PiperOrigin-RevId: 435457762
2022-03-17 22:01:17 +00:00
@$(call configure_noreload,$(RUNTIME)-systemd-d,--net-raw --debug --strace --log-packets --systemd-cgroup)
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call reload_docker)
.PHONY: dev
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
##
## Canonical build and test targets.
##
## These targets are used by continuous integration and provide
## convenient entrypoints for testing changes. If you're adding a
## new subsystem or workflow, consider adding a new target here.
##
Clean up build output. This change also simplifies and documents the build_cmd pipeline, and reduces general noise for debugging Makefile issues. It also drops the mapping for /etc/docker/daemon.json, which if it does not exist initially will create this as a directory (causing lots of confusion and breaks). PiperOrigin-RevId: 343932456
2020-11-23 22:43:42 +00:00
## Some targets support a PARTITION (1-indexed) and TOTAL_PARTITIONS
## environment variables for high-level test sharding. Unlike most
## other variables, these are sourced from the environment.
##
PARTITION ?= 1
TOTAL_PARTITIONS ?= 1
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
PARTITIONS := --test_env=PARTITION=$(PARTITION) --test_env=TOTAL_PARTITIONS=$(TOTAL_PARTITIONS)
Clean up build output. This change also simplifies and documents the build_cmd pipeline, and reduces general noise for debugging Makefile issues. It also drops the mapping for /etc/docker/daemon.json, which if it does not exist initially will create this as a directory (causing lots of confusion and breaks). PiperOrigin-RevId: 343932456
2020-11-23 22:43:42 +00:00
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
runsc: ## Builds the runsc binary.
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call build,-c opt //runsc)
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
.PHONY: runsc
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
debian: ## Builds the debian packages.
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call build,-c opt //debian:debian)
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: debian
Ensure that nogo is enabled. A recent change stopped using the correct file (the export data, not the archive) and checklocks started failing. Unfortunately, this was suppressed, since the filter command was not failing with findings. This change fixes that problem and adds a test to ensure that this cannot happen again. If nogo starts failing to identify problems, the sanity_test in nogo/sanity will also start to fail. This change also requires updating the WORKSPACE to the latest rules_go and Go version, in order to pick up the fixed go_tools. The latest rules_go in turn required an updated bazel, which in turn required a minor change in the coverdata implementation. Fixing the fact propagation brought forward a number of problems with caching for bazel workers. Its unclear whether this was a core worker issue or whether some caching was broken, but the situation was basically undebugable. Instead, the way facts are stored and loaded is optimized to be able to remove the use of workers altogether and ideally make nogo debuggable. PiperOrigin-RevId: 426327186
2022-02-04 07:43:51 +00:00
smoke-tests: ## Runs a simple smoke test after building runsc.
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call run,//runsc,--alsologtostderr --network none --debug --TESTONLY-unsafe-nonroot=true --rootless do true)
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
.PHONY: smoke-tests
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Ensure that nogo is enabled. A recent change stopped using the correct file (the export data, not the archive) and checklocks started failing. Unfortunately, this was suppressed, since the filter command was not failing with findings. This change fixes that problem and adds a test to ensure that this cannot happen again. If nogo starts failing to identify problems, the sanity_test in nogo/sanity will also start to fail. This change also requires updating the WORKSPACE to the latest rules_go and Go version, in order to pick up the fixed go_tools. The latest rules_go in turn required an updated bazel, which in turn required a minor change in the coverdata implementation. Fixing the fact propagation brought forward a number of problems with caching for bazel workers. Its unclear whether this was a core worker issue or whether some caching was broken, but the situation was basically undebugable. Instead, the way facts are stored and loaded is optimized to be able to remove the use of workers altogether and ideally make nogo debuggable. PiperOrigin-RevId: 426327186
2022-02-04 07:43:51 +00:00
smoke-race-tests: ## Runs a smoke test after build building runsc in race configuration.
@$(call run,$(RACE_FLAGS) //runsc:runsc-race,--alsologtostderr --network none --debug --TESTONLY-unsafe-nonroot=true --rootless do true)
.PHONY: smoke-race-tests
[op] Split nogo target out of unit tests. Building nogo targets takes a very long time. This change extracts it into its own BuildKite job. This change also additionally speeds up other targets that were using the bazel flag --test_tag_filters. Without --build_tag_filters, the filter is not applied while building the specified targets and so we might end up building targets that are not actually tested. PiperOrigin-RevId: 368918211
2021-04-16 21:18:51 +00:00
nogo-tests:
make: set --//tools/nogo:fast by default nogo:fast is converted to nogo:full with the opposite meaning. All nogo tests have to be always executed with this option. Analyzing Go Standard Library takes about 10 minutes on buildkite, but it is required only to run nogo tests. PiperOrigin-RevId: 438343203
2022-03-30 17:50:36 +00:00
@$(call test,--build_tag_filters=nogo --test_tag_filters=nogo --//tools/nogo:full //:all pkg/... tools/...)
[op] Split nogo target out of unit tests. Building nogo targets takes a very long time. This change extracts it into its own BuildKite job. This change also additionally speeds up other targets that were using the bazel flag --test_tag_filters. Without --build_tag_filters, the filter is not applied while building the specified targets and so we might end up building targets that are not actually tested. PiperOrigin-RevId: 368918211
2021-04-16 21:18:51 +00:00
.PHONY: nogo-tests
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
# For unit tests, we take everything in the root, pkg/... and tools/..., and
# pull in all directories in runsc except runsc/container.
Split container tests from unit tests. PiperOrigin-RevId: 351632484
2021-01-13 19:46:25 +00:00
unit-tests: ## Local package unit tests in pkg/..., tools/.., etc.
Refactor nogo and provide facts render. This change makes the core nogo package less of a "catch all", and splits functionality into multiple packages. Instead of separate binaries for each function, a single "cli" package is added with subcommands, and the core starlark wrappers are also refactored to minimize redundancy. The new "cli" package also adds support for a "render" command, which allows factors to be rendered via a Go text template. This is useful for debugging, but also allows code generation to be updated to use this mechanism. This eliminates the use of a QEMU wrapper for the older arch_genrule, and allows the use of a native bazel transition to extract facts for the appropriate generated file. In other words, the correct facts will be rendered for generating XXX_arm64.s, even on amd64. PiperOrigin-RevId: 422846459
2022-01-19 18:22:48 +00:00
@$(call test,--build_tag_filters=-nogo --test_tag_filters=-nogo --test_filter=-//runsc/container/... //:all pkg/... tools/... runsc/... vdso/...)
Port fuse tests to Makefile. PiperOrigin-RevId: 332878900
2020-09-21 17:25:41 +00:00
.PHONY: unit-tests
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
# See unit-tests: this includes runsc/container.
container-tests: $(RUNTIME_BIN) ## Run all tests in runsc/container/...
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
@$(call test,--test_env=RUNTIME=$(RUNTIME_BIN) runsc/container/...)
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
.PHONY: container-tests
Split container tests from unit tests. PiperOrigin-RevId: 351632484
2021-01-13 19:46:25 +00:00
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
tests: ## Runs all unit tests and syscall tests.
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
tests: unit-tests nogo-tests container-tests syscall-tests
Standardize all Docker images. This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-04-24 21:10:28 +00:00
.PHONY: tests
gvisor: run bazel in a docker container bazel has a lot of dependencies and users don't want to install them just to build gvisor. These changes allows to run bazel in a docker container. A bazel cache is on the local file system (~/.cache/bazel), so incremental builds should be fast event after recreating a bazel container. Here is an example how to build runsc: make BAZEL_OPTIONS="build runsc:runsc" bazel Change-Id: I8c0a6d0c30e835892377fb6dd5f4af7a0052d12a PiperOrigin-RevId: 246570877
2019-05-03 21:11:55 +00:00
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
integration-tests: ## Run all standard integration tests.
integration-tests: docker-tests overlay-tests hostnet-tests swgso-tests
cgroupv2: skip tests on containerd < 1.4 containerd < 1.4 does not support cgroupv2, so we adjust the Make targets and installer scripts to skip test run on those versions. Signed-off-by: Daniel Dao <dqminh89@gmail.com>
2021-02-04 13:53:48 +00:00
integration-tests: do-tests kvm-tests containerd-tests-min
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: integration-tests
network-tests: ## Run all networking integration tests.
network-tests: iptables-tests packetdrill-tests packetimpact-tests
.PHONY: network-tests
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
syscall-tests: $(RUNTIME_BIN) ## Run all system call tests.
@$(call test,--test_env=RUNTIME=$(RUNTIME_BIN) $(PARTITIONS) test/syscalls/... test/fuse/...)
Clean test tags. PiperOrigin-RevId: 369505182
2021-04-20 20:09:36 +00:00
.PHONY: syscall-tests
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
Remove unused docker image - Remove packetimpact docker image - Update Makefile to remove unnecessary steps - Remove unused runner flags PiperOrigin-RevId: 416621865
2021-12-15 20:31:05 +00:00
packetimpact-tests:
@$(call test,--jobs=HOST_CPUS*3 --local_test_jobs=HOST_CPUS*3 //test/packetimpact/tests:all_tests)
.PHONY: packetimpact-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
%-runtime-tests: load-runtimes_% $(RUNTIME_BIN)
Make watchdog panic for runtime tests. This will make deadlocks more apparent in test results. Currently runtime tests just timeout after 30 mins if there is some deadlock. PiperOrigin-RevId: 433654750
2022-03-10 05:44:30 +00:00
@$(call install_runtime,$(RUNTIME),--watchdog-action=panic)
@$(call test_runtime,$(RUNTIME),--test_timeout=1800 //test/runtimes:$*)
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
Enable all tests for lisafs. - Generates a lisafs variant of all syscall tests. - Adds Makefile targets to run runtime tests with lisafs. We run runtime tests continuously (on every commit to master) and on presubmits iff the commit message contains "lisafs". - Updates the docker tests target to run the integration tests with lisafs too. Fixes #5466 PiperOrigin-RevId: 433782954
2022-03-10 18:06:43 +00:00
%-runtime-tests_lisafs: load-runtimes_% $(RUNTIME_BIN)
test/runtime: add the timeout option for proctor proctor is running in a sandbox and it executes tests. If it is able to handle timeouts, we will know that a test sandbox is alive and proctor will send SIGTERM to test processes and collect all logs. In addition, these changes contains a few things: * upload runsc logs with other test artifacts. * increase log level for java tests. * call Fatalf instead of Errorf when we want to terminate a test. PiperOrigin-RevId: 437385756
2022-03-26 02:36:09 +00:00
@$(call install_runtime,$(RUNTIME), --lisafs --watchdog-action=panic)
@$(call test_runtime,$(RUNTIME),--test_timeout=1800 //test/runtimes:$*)
Enable all tests for lisafs. - Generates a lisafs variant of all syscall tests. - Adds Makefile targets to run runtime tests with lisafs. We run runtime tests continuously (on every commit to master) and on presubmits iff the commit message contains "lisafs". - Updates the docker tests target to run the integration tests with lisafs too. Fixes #5466 PiperOrigin-RevId: 433782954
2022-03-10 18:06:43 +00:00
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
do-tests: $(RUNTIME_BIN)
@$(RUNTIME_BIN) --rootless do true
@$(RUNTIME_BIN) --rootless -network=none do true
@sudo $(RUNTIME_BIN) do true
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: do-tests
Make release pipeline architecture-independent. PiperOrigin-RevId: 432006218
2022-03-02 20:48:20 +00:00
arm-qemu-smoke-test: BAZEL_OPTIONS=--config=aarch64
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
arm-qemu-smoke-test: $(RUNTIME_BIN) load-arm-qemu
Add ARM smoke test make BAZEL_CONFIG=aarch64 arm-qemu-smoke-test Signed-off-by: Andrei Vagin <avagin@gmail.com>
2020-12-30 09:28:26 +00:00
export T=$$(mktemp -d --tmpdir release.XXXXXX); \
mkdir -p $$T/bin/arm64/ && \
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
cp $(RUNTIME_BIN) $$T/bin/arm64 && \
Add ARM smoke test make BAZEL_CONFIG=aarch64 arm-qemu-smoke-test Signed-off-by: Andrei Vagin <avagin@gmail.com>
2020-12-30 09:28:26 +00:00
docker run --rm -v $$T/bin/arm64/runsc:/workdir/initramfs/runsc gvisor.dev/images/arm-qemu
.PHONY: arm-qemu-smoke-test
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
simple-tests: unit-tests # Compatibility target.
.PHONY: simple-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
# Standard integration targets.
INTEGRATION_TARGETS := //test/image:image_test //test/e2e:integration_test
docker-tests: load-basic $(RUNTIME_BIN)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),) # Clear flags.
@$(call test_runtime,$(RUNTIME),$(INTEGRATION_TARGETS))
Enable all tests for lisafs. - Generates a lisafs variant of all syscall tests. - Adds Makefile targets to run runtime tests with lisafs. We run runtime tests continuously (on every commit to master) and on presubmits iff the commit message contains "lisafs". - Updates the docker tests target to run the integration tests with lisafs too. Fixes #5466 PiperOrigin-RevId: 433782954
2022-03-10 18:06:43 +00:00
@$(call install_runtime,$(RUNTIME), --lisafs) # Run again with lisafs.
@$(call test_runtime,$(RUNTIME),$(INTEGRATION_TARGETS))
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: docker-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
overlay-tests: load-basic $(RUNTIME_BIN)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),--overlay)
@$(call test_runtime,$(RUNTIME),$(INTEGRATION_TARGETS))
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: overlay-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
swgso-tests: load-basic $(RUNTIME_BIN)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),--software-gso=true --gso=false)
@$(call test_runtime,$(RUNTIME),$(INTEGRATION_TARGETS))
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: swgso-tests
Fix root tests target in Makefile. PiperOrigin-RevId: 332358833
2020-09-18 01:25:20 +00:00
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
hostnet-tests: load-basic $(RUNTIME_BIN)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),--network=host)
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
@$(call test_runtime,$(RUNTIME),--test_env=CHECKPOINT=false --test_env=HOSTNET=true $(INTEGRATION_TARGETS))
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: hostnet-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
kvm-tests: load-basic $(RUNTIME_BIN)
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
@(lsmod | grep -E '^(kvm_intel|kvm_amd)') || sudo modprobe kvm
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@if ! test -w /dev/kvm; then sudo chmod a+rw /dev/kvm; fi
@$(call test,//pkg/sentry/platform/kvm:kvm_test)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),--platform=kvm)
@$(call test_runtime,$(RUNTIME),$(INTEGRATION_TARGETS))
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: kvm-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
iptables-tests: load-iptables $(RUNTIME_BIN)
ip6tables: filter table support `ip6tables -t filter` is now usable. NAT support will come in a future CL. #3549 PiperOrigin-RevId: 332381801
2020-09-18 04:52:54 +00:00
@sudo modprobe iptable_filter
@sudo modprobe ip6table_filter
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
@sudo modprobe iptable_nat
@sudo modprobe ip6table_nat
@# FIXME(b/218923513): Need to fix permissions issues.
@#$(call test,--test_env=RUNTIME=runc //test/iptables:iptables_test)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),--net-raw)
@$(call test_runtime,$(RUNTIME),//test/iptables:iptables_test)
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: iptables-tests
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
packetdrill-tests: load-packetdrill $(RUNTIME_BIN)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),) # Clear flags.
@$(call test_runtime,$(RUNTIME),//test/packetdrill:all_tests)
Add standard entrypoints for test targets. PiperOrigin-RevId: 322265513
2020-07-21 01:03:04 +00:00
.PHONY: packetdrill-tests
Add fsstress tests Updates #5273 PiperOrigin-RevId: 352088736
2021-01-15 22:49:27 +00:00
fsstress-test: load-basic $(RUNTIME_BIN)
Remove VFS2 test dimension The default is VFS2 enabled, so the tests setting VFS2 are redundant. Updates #1624 PiperOrigin-RevId: 431827013
2022-03-02 02:57:15 +00:00
@$(call install_runtime,$(RUNTIME))
Add fsstress tests Updates #5273 PiperOrigin-RevId: 352088736
2021-01-15 22:49:27 +00:00
@$(call test_runtime,$(RUNTIME),//test/fsstress:fsstress_test)
.PHONY: fsstress-test
Merge pull request #2672 from amscanne:shim-integrated PiperOrigin-RevId: 321053634
2020-07-13 23:10:58 +00:00
# Specific containerd version tests.
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
containerd-test-%: load-basic_alpine load-basic_python load-basic_busybox load-basic_resolv load-basic_httpd load-basic_ubuntu $(RUNTIME_BIN)
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
@$(call install_runtime,$(RUNTIME),) # Clear flags.
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
@sudo tools/install_containerd.sh $*
ifeq (,$(STAGED_BINARIES))
@$(call sudocopy,//shim:containerd-shim-runsc-v1,"$$(dirname $$(which containerd))")
else
gsutil cat "$(STAGED_BINARIES)" | \
sudo tar -C "$$(dirname $$(which containerd))" -zxvf - containerd-shim-runsc-v1
endif
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@$(call sudo,test/root:root_test,--runtime=$(RUNTIME) -test.v)
Update shim to build using bazel. The go.mod dependency tree for the shim was somehow contradictory. After resolving these issues (e.g. explicitly imported k8s 1.14, pulling a specific dbus version), and adding all dependencies, the shim can now be build as part of the regular bazel tree. As part of this process, minor cleanup was done in all the source files: headers were standardized (and include "The gVisor Authors" in addition to the "The containerd Authors" if originally derived from containerd sources), and comments were cleaned up to meet coding standards. This change makes the containerd installation dynamic, so that multiple versions can be tested, and drops the static installer for the VM image itself. This change also updates test/root/crictl_test.go and related utilities, so that the containerd tests can be run on any version (and in cases where it applies, they can be run on both v1 and v2 as parameterized tests).
2020-05-06 05:00:14 +00:00
Drop support for containerd 1.3 Update containerd versions used in test to the latest of each minor version. PiperOrigin-RevId: 431993047
2022-03-02 19:52:23 +00:00
containerd-tests-min: containerd-test-1.4.12
cgroupv2: skip tests on containerd < 1.4 containerd < 1.4 does not support cgroupv2, so we adjust the Make targets and installer scripts to skip test run on those versions. Signed-off-by: Daniel Dao <dqminh89@gmail.com>
2021-02-04 13:53:48 +00:00
Drop support for containerd 1.3 Update containerd versions used in test to the latest of each minor version. PiperOrigin-RevId: 431993047
2022-03-02 19:52:23 +00:00
##
## Containerd tests.
##
## Runs all supported containerd version tests. Update as new versions become
## available.
##
containerd-tests:
containerd-tests: containerd-test-1.4.12
containerd-tests: containerd-test-1.5.9
containerd-tests: containerd-test-1.6.0
Update shim to build using bazel. The go.mod dependency tree for the shim was somehow contradictory. After resolving these issues (e.g. explicitly imported k8s 1.14, pulling a specific dbus version), and adding all dependencies, the shim can now be build as part of the regular bazel tree. As part of this process, minor cleanup was done in all the source files: headers were standardized (and include "The gVisor Authors" in addition to the "The containerd Authors" if originally derived from containerd sources), and comments were cleaned up to meet coding standards. This change makes the containerd installation dynamic, so that multiple versions can be tested, and drops the static installer for the VM image itself. This change also updates test/root/crictl_test.go and related utilities, so that the containerd tests can be run on any version (and in cases where it applies, they can be run on both v1 and v2 as parameterized tests).
2020-05-06 05:00:14 +00:00
Internal Change PiperOrigin-RevId: 340941898
2020-11-05 23:40:54 +00:00
##
## Benchmarks.
##
## Targets to run benchmarks. See //test/benchmarks for details.
##
## common arguments:
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
## BENCHMARKS_PROJECT - BigQuery project to which to send data.
## BENCHMARKS_DATASET - BigQuery dataset to which to send data.
## BENCHMARKS_TABLE - BigQuery table to which to send data.
## BENCHMARKS_SUITE - name of the benchmark suite. See //tools/bigquery/bigquery.go.
## BENCHMARKS_UPLOAD - if true, upload benchmark data from the run.
## BENCHMARKS_OFFICIAL - marks the data as official.
## BENCHMARKS_FILTER - filter to be applied to the test suite.
## BENCHMARKS_OPTIONS - options to be passed to the test.
Don't run profiles on runc. PiperOrigin-RevId: 351906812
2021-01-15 01:02:01 +00:00
## BENCHMARKS_PROFILE - profile options to be passed to the test.
Internal Change PiperOrigin-RevId: 340941898
2020-11-05 23:40:54 +00:00
##
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
BENCHMARKS_PROJECT ?= gvisor-benchmarks
BENCHMARKS_DATASET ?= kokoro
BENCHMARKS_TABLE ?= benchmarks
BENCHMARKS_SUITE ?= ffmpeg
BENCHMARKS_UPLOAD ?= false
BENCHMARKS_OFFICIAL ?= false
BENCHMARKS_TARGETS := //test/benchmarks/media:ffmpeg_test
BENCHMARKS_FILTER := .
Add benchmarks targets to BuildKite. This includes minor fix-ups: * Handle SIGTERM in runsc debug, to exit gracefully. * Fix cmd.debug.go opening all profiles as RDONLY. * Fix the test name in fio_test.go, and encode the block size in the test. PiperOrigin-RevId: 350205718
2021-01-05 21:20:12 +00:00
BENCHMARKS_OPTIONS := -test.benchtime=30s
Don't run profiles on runc. PiperOrigin-RevId: 351906812
2021-01-15 01:02:01 +00:00
BENCHMARKS_ARGS := -test.v -test.bench=$(BENCHMARKS_FILTER) $(BENCHMARKS_OPTIONS)
BENCHMARKS_PROFILE := -pprof-dir=/tmp/profile -pprof-cpu -pprof-heap -pprof-block -pprof-mutex
Internal Change PiperOrigin-RevId: 340941898
2020-11-05 23:40:54 +00:00
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
init-benchmark-table: ## Initializes a BigQuery table with the benchmark schema.
@$(call run,//tools/parsers:parser,init --project=$(BENCHMARKS_PROJECT) --dataset=$(BENCHMARKS_DATASET) --table=$(BENCHMARKS_TABLE))
Internal Change PiperOrigin-RevId: 340941898
2020-11-05 23:40:54 +00:00
.PHONY: init-benchmark-table
[benchmarks] Fix issue with run-benchmark. make run-benchmark should not install a new runtime. Instead, just run the benchmark with the given RUNTIME. Move all of the logic to install the runtime to benchmark-platforms. PiperOrigin-RevId: 434838884
2022-03-15 20:19:32 +00:00
# $(1) is the runtime name.
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
run_benchmark = \
[benchmarks] Fix issue with run-benchmark. make run-benchmark should not install a new runtime. Instead, just run the benchmark with the given RUNTIME. Move all of the logic to install the runtime to benchmark-platforms. PiperOrigin-RevId: 434838884
2022-03-15 20:19:32 +00:00
($(call header,BENCHMARK $(1)); \
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
set -euo pipefail; \
export T=$$(mktemp --tmpdir logs.$(1).XXXXXX); \
Don't run profiles on runc. PiperOrigin-RevId: 351906812
2021-01-15 01:02:01 +00:00
if test "$(1)" = "runc"; then $(call sudo,$(BENCHMARKS_TARGETS),-runtime=$(1) $(BENCHMARKS_ARGS)) | tee $$T; fi; \
[benchmarks] Fix issue with run-benchmark. make run-benchmark should not install a new runtime. Instead, just run the benchmark with the given RUNTIME. Move all of the logic to install the runtime to benchmark-platforms. PiperOrigin-RevId: 434838884
2022-03-15 20:19:32 +00:00
if test "$(1)" != "runc"; then $(call sudo,$(BENCHMARKS_TARGETS),-runtime=$(1) $(BENCHMARKS_ARGS) $(BENCHMARKS_PROFILE)) | tee $$T; fi; \
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
if test "$(BENCHMARKS_UPLOAD)" = "true"; then \
$(call run,tools/parsers:parser,parse --debug --file=$$T --runtime=$(1) --suite_name=$(BENCHMARKS_SUITE) --project=$(BENCHMARKS_PROJECT) --dataset=$(BENCHMARKS_DATASET) --table=$(BENCHMARKS_TABLE) --official=$(BENCHMARKS_OFFICIAL)); \
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
fi; \
Add BuildKite annotations for failures and profiles. This change cleans up some minor Makefile issues, and adds support for BuildKite annotations on failure and on profiles being generated. These annotations will make failures very clear and link to the artifacts. This change is a stepping stone for aggregating coverage data from all individual test jobs, as this will also happen in .buildkite/annotate.sh. PiperOrigin-RevId: 349606598
2020-12-30 23:06:47 +00:00
rm -rf $$T)
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
benchmark-platforms: load-benchmarks $(RUNTIME_BIN) ## Runs benchmarks for runc and all platforms.
@set -xe; for PLATFORM in $$($(RUNTIME_BIN) help platforms); do \
export PLATFORM; \
[benchmarks] Add profiles back to buildkite. PiperOrigin-RevId: 441223389
2022-04-12 17:17:08 +00:00
$(call install_runtime,$${PLATFORM},--platform $${PLATFORM} --profile); \
[benchmarks] Fix issue with run-benchmark. make run-benchmark should not install a new runtime. Instead, just run the benchmark with the given RUNTIME. Move all of the logic to install the runtime to benchmark-platforms. PiperOrigin-RevId: 434838884
2022-03-15 20:19:32 +00:00
$(call run_benchmark,$${PLATFORM}); \
Support STAGED_BINARIES to run prebuilt binaries with the test pipeline. In some cases, it may be desirable to prebuild binaries and run all tests, for example to run benchmarks with various experiments. Allow the top-level Makefile to support this by checking for a STAGED_BINARIES variable. PiperOrigin-RevId: 410673120
2021-11-18 01:47:00 +00:00
done
Fix native benchmarks. PiperOrigin-RevId: 350509137
2021-01-07 09:15:20 +00:00
@$(call run_benchmark,runc)
Internal Change PiperOrigin-RevId: 340941898
2020-11-05 23:40:54 +00:00
.PHONY: benchmark-platforms
[benchmarks] Fix issue with run-benchmark. make run-benchmark should not install a new runtime. Instead, just run the benchmark with the given RUNTIME. Move all of the logic to install the runtime to benchmark-platforms. PiperOrigin-RevId: 434838884
2022-03-15 20:19:32 +00:00
run-benchmark: load-benchmarks ## Runs single benchmark and optionally sends data to BigQuery.
Validate flags during install. First, this change moves the internal config API to use flag.FlagSet, which allows more flexibility and fixes many test usages. Second, the runtime flags are validated during install. The platform is opened and a warning issued if this fails, but this is not fatal. This change requires moving the Makefile to --test_env, since the attribute is not properly supported by test targets. Therefore, the targets can use args while the Makefile must pass in configuration via --test_env. PiperOrigin-RevId: 428048274
2022-02-11 19:21:33 +00:00
@$(call run_benchmark,$(RUNTIME))
Internal Change PiperOrigin-RevId: 340941898
2020-11-05 23:40:54 +00:00
.PHONY: run-benchmark
Adapt website to use g3doc sources and bazel. This adapts the merged website repository to use the image and bazel build framework. It explicitly avoids the container_image rules provided by bazel, opting instead to build with direct docker commands when necessary. The relevant build commands are incorporated into the top-level Makefile.
2020-04-28 05:24:58 +00:00
##
## Website & documentation helpers.
##
## The website is built from repository documentation and wrappers, using
## using a locally-defined Docker image (see images/jekyll). The following
## variables may be set when using website-push:
## WEBSITE_IMAGE - The name of the container image.
## WEBSITE_SERVICE - The backend service.
## WEBSITE_PROJECT - The project id to use.
## WEBSITE_REGION - The region to deploy to.
##
WEBSITE_IMAGE := gcr.io/gvisordev/gvisordev
WEBSITE_SERVICE := gvisordev
WEBSITE_PROJECT := gvisordev
WEBSITE_REGION := us-central1
website-build: load-jekyll ## Build the site image locally.
Fix website build Fix 'run' function call so that parameters are passed properly to the function. PiperOrigin-RevId: 346929952
2020-12-11 05:47:38 +00:00
@$(call run,//website:website,$(WEBSITE_IMAGE))
Adapt website to use g3doc sources and bazel. This adapts the merged website repository to use the image and bazel build framework. It explicitly avoids the container_image rules provided by bazel, opting instead to build with direct docker commands when necessary. The relevant build commands are incorporated into the top-level Makefile.
2020-04-28 05:24:58 +00:00
.PHONY: website-build
website-server: website-build ## Run a local server for development.
Add a platform portability blog post Also fixes the docker_image bazel rule, and website-server make target. Fixes #3273 PiperOrigin-RevId: 338606668
2020-10-23 04:21:16 +00:00
@docker run -i -p 8080:8080 $(WEBSITE_IMAGE)
Adapt website to use g3doc sources and bazel. This adapts the merged website repository to use the image and bazel build framework. It explicitly avoids the container_image rules provided by bazel, opting instead to build with direct docker commands when necessary. The relevant build commands are incorporated into the top-level Makefile.
2020-04-28 05:24:58 +00:00
.PHONY: website-server
website-push: website-build ## Push a new image and update the service.
Add easier-to-use docker_image target. PiperOrigin-RevId: 337415009
2020-10-16 00:19:21 +00:00
@docker push $(WEBSITE_IMAGE)
Adapt website to use g3doc sources and bazel. This adapts the merged website repository to use the image and bazel build framework. It explicitly avoids the container_image rules provided by bazel, opting instead to build with direct docker commands when necessary. The relevant build commands are incorporated into the top-level Makefile.
2020-04-28 05:24:58 +00:00
.PHONY: website-push
website-deploy: website-push ## Deploy a new version of the website.
Export a pprof visualization endpoint. This allows us to link directly to profiling results from the build results. The code uses the standard pprof http server, exported from the Cloud Run instance. PiperOrigin-RevId: 350440910
2021-01-06 23:36:23 +00:00
@gcloud run deploy $(WEBSITE_SERVICE) --platform=managed --region=$(WEBSITE_REGION) --project=$(WEBSITE_PROJECT) --image=$(WEBSITE_IMAGE) --memory 1Gi
Fix PHONY target typos PiperOrigin-RevId: 324305107
2020-07-31 23:18:23 +00:00
.PHONY: website-deploy
Adapt website to use g3doc sources and bazel. This adapts the merged website repository to use the image and bazel build framework. It explicitly avoids the container_image rules provided by bazel, opting instead to build with direct docker commands when necessary. The relevant build commands are incorporated into the top-level Makefile.
2020-04-28 05:24:58 +00:00
Make the webhook deterministic. We add a simple image that will generate certificates as a init container, and refer to this directly use the Kubernetes yaml. Note that this also fixes the issue of versioning within the yaml file, as this will now generate a version of this file that refers to the precise local versions. PiperOrigin-RevId: 421671040
2022-01-13 23:17:44 +00:00
##
## Webhook helpers.
##
## The webhook is built locally.
## WEBHOOK_IMAGE - The name of the container image.
##
WEBHOOK_IMAGE := gcr.io/gvisor-presubmit/webhook
webhook-build: ## Build the webhookimage locally.
@$(call run,//webhook:image,$(WEBHOOK_IMAGE))
.PHONY: webhook-build
webhook-push: webhook-build ## Push a new image.
@docker push $(WEBHOOK_IMAGE)
.PHONY: website-push
webhook-update: test/kubernetes/gvisor-injection-admission-webhook.yaml.in
@WEBHOOK=$(WEBHOOK_IMAGE):$$($(call run,//webhook:image,$(WEBHOOK_IMAGE)) | cut -d':' -f2) && \
INIT=$(call remote_image,certs):$(call tag,certs) && \
cat $< | sed -e "s|%WEBHOOK%|$${WEBHOOK}|g" | sed -e "s|%INIT%|$${INIT}|g" > test/kubernetes/gvisor-injection-admission-webhook.yaml
.PHONY: webhook-update
Fix the APT repository structure. This change fixes the apt repository structure to avoid emiting warnings on Ubuntu 18.04 (and potentially other versions). This requires a slight refactor of the repository generation scripts, since we can no longer copy the same release files for different "suites". This should avoid the warning by setting the suite to the distribution: https://github.com/Debian/apt/blob/master/apt-pkg/metaindex.cc#L75 This change also moves over to the standardized Makefile entrypoint, which makes settings clearer and enables local testing. PiperOrigin-RevId: 313817017
2020-05-29 18:23:50 +00:00
##
## Repository builders.
##
## This builds a local apt repository. The following variables may be set:
Support releasing aarch64 builds. This change works around an issue in rules_pkg, described here: https://github.com/bazelbuild/rules_pkg/pull/263 PiperOrigin-RevId: 350869030
2021-01-09 02:01:05 +00:00
## RELEASE_ROOT - The repository root (default: "repo" directory).
## RELEASE_KEY - The repository GPG private key file (default: dummy key is created).
## RELEASE_ARTIFACTS - The release artifacts directory. May contain multiple.
## RELEASE_NIGHTLY - Set to true if a nightly release (default: false).
## RELEASE_COMMIT - The commit or Change-Id for the release (needed for tag).
## RELEASE_NAME - The name of the release in the proper format (needed for tag).
## RELEASE_NOTES - The file containing release notes (needed for tag).
Fix the APT repository structure. This change fixes the apt repository structure to avoid emiting warnings on Ubuntu 18.04 (and potentially other versions). This requires a slight refactor of the repository generation scripts, since we can no longer copy the same release files for different "suites". This should avoid the warning by setting the suite to the distribution: https://github.com/Debian/apt/blob/master/apt-pkg/metaindex.cc#L75 This change also moves over to the standardized Makefile entrypoint, which makes settings clearer and enables local testing. PiperOrigin-RevId: 313817017
2020-05-29 18:23:50 +00:00
##
Support releasing aarch64 builds. This change works around an issue in rules_pkg, described here: https://github.com/bazelbuild/rules_pkg/pull/263 PiperOrigin-RevId: 350869030
2021-01-09 02:01:05 +00:00
RELEASE_ROOT := repo
RELEASE_KEY := repo.key
RELEASE_ARTIFACTS := artifacts
RELEASE_NIGHTLY := false
RELEASE_COMMIT :=
RELEASE_NAME :=
RELEASE_NOTES :=
GPG_TEST_OPTIONS := $(shell if gpg --pinentry-mode loopback --version >/dev/null 2>&1; then echo --pinentry-mode loopback; fi)
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
Fix the APT repository structure. This change fixes the apt repository structure to avoid emiting warnings on Ubuntu 18.04 (and potentially other versions). This requires a slight refactor of the repository generation scripts, since we can no longer copy the same release files for different "suites". This should avoid the warning by setting the suite to the distribution: https://github.com/Debian/apt/blob/master/apt-pkg/metaindex.cc#L75 This change also moves over to the standardized Makefile entrypoint, which makes settings clearer and enables local testing. PiperOrigin-RevId: 313817017
2020-05-29 18:23:50 +00:00
$(RELEASE_KEY):
@echo "WARNING: Generating a key for testing ($@); don't use this."
Refactor the Makefile to avoid recursive Make. Recursive make is difficult to follow and debug. Drop this by using internal functions, which, while difficult, are easier than trying to following recursive invokations. Further simplify the Makefile by collapsing the image bits and removing the tools/vm directory, which is effectively unused. Fixes #4952 PiperOrigin-RevId: 346569133
2020-12-09 17:31:44 +00:00
@T=$$(mktemp --tmpdir keyring.XXXXXX); \
Show run-benchmark output. PiperOrigin-RevId: 341667792
2020-11-10 19:59:15 +00:00
C=$$(mktemp --tmpdir config.XXXXXX); \
Fix test release commands to work with older GPG. The --quick-generate-key command wasn't added until recently. PiperOrigin-RevId: 314570297
2020-06-03 18:30:49 +00:00
echo Key-Type: DSA >> $$C && \
echo Key-Length: 1024 >> $$C && \
echo Name-Real: Test >> $$C && \
echo Name-Email: test@example.com >> $$C && \
echo Expire-Date: 0 >> $$C && \
echo %commit >> $$C && \
Fix make_apt script. This change makes the following fixes: - When creating a test repo.key, create a secret keyring as other workflows also use secret keyrings only. - We should not be using both --keyring and --secret-keyring options. Just use --secret-keyring. - Pass homedir to all gpg commands. dpkg-sig takes an arg -g which stands for gpgopts. So we need to pass the homedir there too. PiperOrigin-RevId: 330443280
2020-09-08 04:16:22 +00:00
gpg --batch $(GPG_TEST_OPTIONS) --passphrase '' --no-default-keyring --secret-keyring $$T --no-tty --gen-key $$C && \
gpg --batch $(GPG_TEST_OPTIONS) --export-secret-keys --no-default-keyring --secret-keyring $$T > $@; \
Fix test release commands to work with older GPG. The --quick-generate-key command wasn't added until recently. PiperOrigin-RevId: 314570297
2020-06-03 18:30:49 +00:00
rc=$$?; rm -f $$T $$C; exit $$rc
Fix the APT repository structure. This change fixes the apt repository structure to avoid emiting warnings on Ubuntu 18.04 (and potentially other versions). This requires a slight refactor of the repository generation scripts, since we can no longer copy the same release files for different "suites". This should avoid the warning by setting the suite to the distribution: https://github.com/Debian/apt/blob/master/apt-pkg/metaindex.cc#L75 This change also moves over to the standardized Makefile entrypoint, which makes settings clearer and enables local testing. PiperOrigin-RevId: 313817017
2020-05-29 18:23:50 +00:00
Support releasing aarch64 builds. This change works around an issue in rules_pkg, described here: https://github.com/bazelbuild/rules_pkg/pull/263 PiperOrigin-RevId: 350869030
2021-01-09 02:01:05 +00:00
$(RELEASE_ARTIFACTS)/%:
@mkdir -p $@
@$(call copy,//runsc:runsc,$@)
Delete shim v1 gvisor-containerd-shim is not compatible with containerd 1.1 or earlier. Starting from containerd 1.2, shim v2 is the preferred interface. PiperOrigin-RevId: 351485556
2021-01-13 01:50:33 +00:00
@$(call copy,//shim:containerd-shim-runsc-v1,$@)
Use --output=starlark trick for all build path parsing. There is no reason to limit this to debian paths. PiperOrigin-RevId: 392469415
2021-08-23 17:50:37 +00:00
@$(call copy,//debian:debian,$@)
Support releasing aarch64 builds. This change works around an issue in rules_pkg, described here: https://github.com/bazelbuild/rules_pkg/pull/263 PiperOrigin-RevId: 350869030
2021-01-09 02:01:05 +00:00
release: $(RELEASE_KEY) $(RELEASE_ARTIFACTS)/$(ARCH)
Don't remove release directory. If the release directory is a parent directory (for reasons), then this causes a few problems (to say the least). PiperOrigin-RevId: 351515882
2021-01-13 06:23:13 +00:00
@mkdir -p $(RELEASE_ROOT)
Support releasing aarch64 builds. This change works around an issue in rules_pkg, described here: https://github.com/bazelbuild/rules_pkg/pull/263 PiperOrigin-RevId: 350869030
2021-01-09 02:01:05 +00:00
@NIGHTLY=$(RELEASE_NIGHTLY) tools/make_release.sh $(RELEASE_KEY) $(RELEASE_ROOT) $$(find $(RELEASE_ARTIFACTS) -type f)
Fix the APT repository structure. This change fixes the apt repository structure to avoid emiting warnings on Ubuntu 18.04 (and potentially other versions). This requires a slight refactor of the repository generation scripts, since we can no longer copy the same release files for different "suites". This should avoid the warning by setting the suite to the distribution: https://github.com/Debian/apt/blob/master/apt-pkg/metaindex.cc#L75 This change also moves over to the standardized Makefile entrypoint, which makes settings clearer and enables local testing. PiperOrigin-RevId: 313817017
2020-05-29 18:23:50 +00:00
.PHONY: release
Move to make for tag release workflow. This will make tag & release workflows idempotent. PiperOrigin-RevId: 314154888
2020-06-01 17:27:59 +00:00
tag: ## Creates and pushes a release tag.
@tools/tag_release.sh "$(RELEASE_COMMIT)" "$(RELEASE_NAME)" "$(RELEASE_NOTES)"
.PHONY: tag