go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update privateunixsocket TODOs. 

Synthetic sockets do not have the race condition issue in VFS2, and we will
get rid of privateunixsocket as well.

Fixes #1200.

PiperOrigin-RevId: 310386474
This commit is contained in:
Dean Deng 2020-05-07 10:19:11 -07:00 committed by gVisor bot
parent 553da2cdc8
commit 16da7e790f
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/sentry/fs/gofer/session.go
View File

@ -190,9 +190,9 @@ type session struct {
// be socket/pipe files. This allows unix domain sockets and named pipes to
// be used with paths that belong to a gofer.
//
// TODO(gvisor.dev/issue/1200): there are few possible races with someone
// stat'ing the file and another deleting it concurrently, where the file
// will not be reported as socket file.
// There are a few possible races with someone stat'ing the file and another
// deleting it concurrently, where the file will not be reported as socket
// file.
overrides *overrideMaps `state:"wait"`
}

4
runsc/boot/vfs.go
View File

@ -301,8 +301,8 @@ func (c *containerMounter) getMountNameAndOptionsVFS2(conf *Config, m specs.Moun
}
// p9MountOptions creates a slice of options for a p9 mount.
// TODO(gvisor.dev/issue/1200): Remove this version in favor of the one in
// fs.go when privateunixsocket lands.
// TODO(gvisor.dev/issue/1624): Remove this version once privateunixsocket is
// deleted, along with the rest of VFS1.
func p9MountOptionsVFS2(fd int, fa FileAccessType) []string {
opts := []string{
"trans=fd",