go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix BadSocketPair for open source. 

BadSocketPair test will return several errnos (EPREM, ESOCKTNOSUPPORT,
EAFNOSUPPORT) meaning the test is just too specific. Checking the syscall
fails is appropriate.

PiperOrigin-RevId: 328813071
This commit is contained in:
Zach Koopmans 2020-08-27 14:09:25 -07:00 committed by gVisor bot
parent a5f1e74260
commit 26c588f063
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/syscalls/linux/socket_inet_loopback.cc
View File

@ -97,13 +97,9 @@ TEST(BadSocketPairArgs, ValidateErrForBadCallsToSocketPair) {
ASSERT_THAT(socketpair(AF_INET6, 0, 0, fd),
SyscallFailsWithErrno(ESOCKTNOSUPPORT));
// Invalid AF will return ENOAFSUPPORT or EPERM.
ASSERT_THAT(socketpair(AF_MAX, 0, 0, fd),
::testing::AnyOf(SyscallFailsWithErrno(EAFNOSUPPORT),
SyscallFailsWithErrno(EPERM)));
ASSERT_THAT(socketpair(8675309, 0, 0, fd),
::testing::AnyOf(SyscallFailsWithErrno(EAFNOSUPPORT),
SyscallFailsWithErrno(EPERM)));
// Invalid AF will fail.
ASSERT_THAT(socketpair(AF_MAX, 0, 0, fd), SyscallFails());
ASSERT_THAT(socketpair(8675309, 0, 0, fd), SyscallFails());
}
enum class Operation {