Direct gvisor.dev/issues to the same place as gvisor.dev/issue.
Also let the Github bug reviver detect both in TODOs. PiperOrigin-RevId: 338785089
This commit is contained in:
parent
8dfbec28a4
commit
54d2d927ac
|
@ -121,13 +121,24 @@ func (b *GitHubBugger) Activate(todo *Todo) (bool, error) {
|
|||
return true, nil
|
||||
}
|
||||
|
||||
// parseIssueNo parses the issue number out of the issue url.
|
||||
func parseIssueNo(url string) (int, error) {
|
||||
const prefix = "gvisor.dev/issue/"
|
||||
var issuePrefixes = []string{
|
||||
"gvisor.dev/issue/",
|
||||
"gvisor.dev/issues/",
|
||||
}
|
||||
|
||||
// parseIssueNo parses the issue number out of the issue url.
|
||||
//
|
||||
// 0 is returned if url does not correspond to an issue.
|
||||
func parseIssueNo(url string) (int, error) {
|
||||
// First check if I can handle the TODO.
|
||||
idStr := strings.TrimPrefix(url, prefix)
|
||||
if len(url) == len(idStr) {
|
||||
var idStr string
|
||||
for _, p := range issuePrefixes {
|
||||
if str := strings.TrimPrefix(url, p); len(str) < len(url) {
|
||||
idStr = str
|
||||
break
|
||||
}
|
||||
}
|
||||
if len(idStr) == 0 {
|
||||
return 0, nil
|
||||
}
|
||||
|
||||
|
|
|
@ -32,6 +32,15 @@ func TestProcessLine(t *testing.T) {
|
|||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
line: "// TODO(foobar.com/issues/123): comment, bla. blabla.",
|
||||
want: &Todo{
|
||||
Issue: "foobar.com/issues/123",
|
||||
Locations: []Location{
|
||||
{Comment: "comment, bla. blabla."},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
line: "// FIXME(b/123): internal bug",
|
||||
want: &Todo{
|
||||
|
|
|
@ -29,6 +29,7 @@ var redirects = map[string]string{
|
|||
// GitHub redirects.
|
||||
"/change": "https://github.com/google/gvisor",
|
||||
"/issue": "https://github.com/google/gvisor/issues",
|
||||
"/issues": "https://github.com/google/gvisor/issues",
|
||||
"/issue/new": "https://github.com/google/gvisor/issues/new",
|
||||
"/pr": "https://github.com/google/gvisor/pulls",
|
||||
|
||||
|
@ -60,6 +61,7 @@ var redirects = map[string]string{
|
|||
var prefixHelpers = map[string]string{
|
||||
"change": "https://github.com/google/gvisor/commit/%s",
|
||||
"issue": "https://github.com/google/gvisor/issues/%s",
|
||||
"issues": "https://github.com/google/gvisor/issues/%s",
|
||||
"pr": "https://github.com/google/gvisor/pull/%s",
|
||||
|
||||
// Redirects to compatibility docs.
|
||||
|
|
Loading…
Reference in New Issue