From 582f7bf6c0ccccaeb1215a232709df38d5d409f7 Mon Sep 17 00:00:00 2001
From: Fabricio Voznika <fvoznika@google.com>
Date: Thu, 18 Feb 2021 10:17:07 -0800
Subject: [PATCH] Remove side effect from pty tests

Individual test cases must not rely on being executed in a clean environment.

PiperOrigin-RevId: 358207468
---
 test/syscalls/linux/pty.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/syscalls/linux/pty.cc b/test/syscalls/linux/pty.cc
index e6b12f81c..294b9f6fd 100644
--- a/test/syscalls/linux/pty.cc
+++ b/test/syscalls/linux/pty.cc
@@ -1316,7 +1316,10 @@ class JobControlTest : public ::testing::Test {
     // In the gVisor test environment, this test will be run as the session
     // leader already (as the sentry init process).
     if (!IsRunningOnGvisor()) {
-      ASSERT_THAT(setsid(), SyscallSucceeds());
+      // Ignore failure because setsid(2) fails if the process is already the
+      // session leader.
+      setsid();
+      ioctl(replica_.get(), TIOCNOTTY);
     }
   }