go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add list of stuck tasks to panic message 

PiperOrigin-RevId: 254450309
This commit is contained in:
Fabricio Voznika 2019-06-21 12:45:50 -07:00 committed by gVisor bot
parent c0317b28cb
commit 5ba16d51a9
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/sentry/watchdog/watchdog.go
View File

@ -271,23 +271,23 @@ func (w *Watchdog) reportStuckWatchdog() {
w.onStuckTask(true, &buf)
}
func (w *Watchdog) onStuckTask(newTaskFound bool, buf *bytes.Buffer) {
func (w *Watchdog) onStuckTask(newTaskFound bool, msg *bytes.Buffer) {
switch w.timeoutAction {
case LogWarning:
// Dump stack only if a new task is detected or if it sometime has passed since
// the last time a stack dump was generated.
if !newTaskFound && time.Since(w.lastStackDump) < stackDumpSameTaskPeriod {
buf.WriteString("\n...[stack dump skipped]...")
log.Warningf(buf.String())
msg.WriteString("\n...[stack dump skipped]...")
log.Warningf(msg.String())
} else {
log.TracebackAll(buf.String())
log.TracebackAll(msg.String())
w.lastStackDump = time.Now()
}
case Panic:
// Panic will skip over running tasks, which is likely the culprit here. So manually
// dump all stacks before panic'ing.
log.TracebackAll(buf.String())
log.TracebackAll(msg.String())
// Attempt to flush metrics, timeout and move on in case metrics are stuck as well.
metricsEmitted := make(chan struct{}, 1)
@ -300,6 +300,6 @@ func (w *Watchdog) onStuckTask(newTaskFound bool, buf *bytes.Buffer) {
case <-metricsEmitted:
case <-time.After(1 * time.Second):
}
panic("Sentry detected stuck task(s). See stack trace and message above for more details")
panic(fmt.Sprintf("Stack for running G's are skipped while panicking.\n%s", msg.String()))
}
}