Fix loopback subnet routing error
Packets should be properly routed when sending packets to addresses in the loopback subnet which are not explicitly assigned to the loopback interface. Tests: - integration_test.TestLoopbackAcceptAllInSubnetUDP - integration_test.TestLoopbackAcceptAllInSubnetTCP PiperOrigin-RevId: 343135643
This commit is contained in:
Ghanan Gowripalan
gVisor bot
parent
c978ab0471
commit
60b97bfda6
|
|
@ -71,22 +71,24 @@ type Route struct {
|
|||
// ownership of the provided local address.
|
||||
//
|
||||
// Returns an empty route if validation fails.
|
||||
func constructAndValidateRoute(netProto tcpip.NetworkProtocolNumber, addressEndpoint AssignableAddressEndpoint, localAddressNIC, outgoingNIC *NIC, gateway, remoteAddr tcpip.Address, handleLocal, multicastLoop bool) Route {
|
||||
addrWithPrefix := addressEndpoint.AddressWithPrefix()
|
||||
func constructAndValidateRoute(netProto tcpip.NetworkProtocolNumber, addressEndpoint AssignableAddressEndpoint, localAddressNIC, outgoingNIC *NIC, gateway, localAddr, remoteAddr tcpip.Address, handleLocal, multicastLoop bool) Route {
|
||||
if len(localAddr) == 0 {
|
||||
localAddr = addressEndpoint.AddressWithPrefix().Address
|
||||
}
|
||||
|
||||
if localAddressNIC != outgoingNIC && header.IsV6LinkLocalAddress(addrWithPrefix.Address) {
|
||||
if localAddressNIC != outgoingNIC && header.IsV6LinkLocalAddress(localAddr) {
|
||||
addressEndpoint.DecRef()
|
||||
return Route{}
|
||||
}
|
||||
|
||||
// If no remote address is provided, use the local address.
|
||||
if len(remoteAddr) == 0 {
|
||||
remoteAddr = addrWithPrefix.Address
|
||||
remoteAddr = localAddr
|
||||
}
|
||||
|
||||
r := makeRoute(
|
||||
netProto,
|
||||
addrWithPrefix.Address,
|
||||
localAddr,
|
||||
remoteAddr,
|
||||
outgoingNIC,
|
||||
localAddressNIC,
|
||||
|
|
@ -99,7 +101,7 @@ func constructAndValidateRoute(netProto tcpip.NetworkProtocolNumber, addressEndp
|
|||
// broadcast it.
|
||||
if len(gateway) > 0 {
|
||||
r.NextHop = gateway
|
||||
} else if subnet := addrWithPrefix.Subnet(); subnet.IsBroadcast(remoteAddr) {
|
||||
} else if subnet := addressEndpoint.Subnet(); subnet.IsBroadcast(remoteAddr) {
|
||||
r.RemoteLinkAddress = header.EthernetBroadcastAddress
|
||||
}
|
||||
|
||||
|
|
@ -113,6 +115,10 @@ func makeRoute(netProto tcpip.NetworkProtocolNumber, localAddr, remoteAddr tcpip
|
|||
panic(fmt.Sprintf("cannot create a route with NICs from different stacks"))
|
||||
}
|
||||
|
||||
if len(localAddr) == 0 {
|
||||
localAddr = localAddressEndpoint.AddressWithPrefix().Address
|
||||
}
|
||||
|
||||
loop := PacketOut
|
||||
|
||||
// TODO(gvisor.dev/issue/4689): Loopback interface loops back packets at the
|
||||
|
|
|
|||
|
|
@ -1240,7 +1240,7 @@ func (s *Stack) findLocalRouteFromNICRLocked(localAddressNIC *NIC, localAddr, re
|
|||
|
||||
r := makeLocalRoute(
|
||||
netProto,
|
||||
localAddressEndpoint.AddressWithPrefix().Address,
|
||||
localAddr,
|
||||
remoteAddr,
|
||||
outgoingNIC,
|
||||
localAddressNIC,
|
||||
|
|
@ -1317,7 +1317,7 @@ func (s *Stack) FindRoute(id tcpip.NICID, localAddr, remoteAddr tcpip.Address, n
|
|||
if addressEndpoint := s.getAddressEP(nic, localAddr, remoteAddr, netProto); addressEndpoint != nil {
|
||||
return makeRoute(
|
||||
netProto,
|
||||
addressEndpoint.AddressWithPrefix().Address,
|
||||
localAddr,
|
||||
remoteAddr,
|
||||
nic, /* outboundNIC */
|
||||
nic, /* localAddressNIC*/
|
||||
|
|
@ -1354,7 +1354,7 @@ func (s *Stack) FindRoute(id tcpip.NICID, localAddr, remoteAddr tcpip.Address, n
|
|||
if needRoute {
|
||||
gateway = route.Gateway
|
||||
}
|
||||
r := constructAndValidateRoute(netProto, addressEndpoint, nic /* outgoingNIC */, nic /* outgoingNIC */, gateway, remoteAddr, s.handleLocal, multicastLoop)
|
||||
r := constructAndValidateRoute(netProto, addressEndpoint, nic /* outgoingNIC */, nic /* outgoingNIC */, gateway, localAddr, remoteAddr, s.handleLocal, multicastLoop)
|
||||
if r == (Route{}) {
|
||||
panic(fmt.Sprintf("non-forwarding route validation failed with route table entry = %#v, id = %d, localAddr = %s, remoteAddr = %s", route, id, localAddr, remoteAddr))
|
||||
}
|
||||
|
|
@ -1391,7 +1391,7 @@ func (s *Stack) FindRoute(id tcpip.NICID, localAddr, remoteAddr tcpip.Address, n
|
|||
if id != 0 {
|
||||
if aNIC, ok := s.nics[id]; ok {
|
||||
if addressEndpoint := s.getAddressEP(aNIC, localAddr, remoteAddr, netProto); addressEndpoint != nil {
|
||||
if r := constructAndValidateRoute(netProto, addressEndpoint, aNIC /* localAddressNIC */, nic /* outgoingNIC */, gateway, remoteAddr, s.handleLocal, multicastLoop); r != (Route{}) {
|
||||
if r := constructAndValidateRoute(netProto, addressEndpoint, aNIC /* localAddressNIC */, nic /* outgoingNIC */, gateway, localAddr, remoteAddr, s.handleLocal, multicastLoop); r != (Route{}) {
|
||||
return r, nil
|
||||
}
|
||||
}
|
||||
|
|
@ -1409,7 +1409,7 @@ func (s *Stack) FindRoute(id tcpip.NICID, localAddr, remoteAddr tcpip.Address, n
|
|||
continue
|
||||
}
|
||||
|
||||
if r := constructAndValidateRoute(netProto, addressEndpoint, aNIC /* localAddressNIC */, nic /* outgoingNIC */, gateway, remoteAddr, s.handleLocal, multicastLoop); r != (Route{}) {
|
||||
if r := constructAndValidateRoute(netProto, addressEndpoint, aNIC /* localAddressNIC */, nic /* outgoingNIC */, gateway, localAddr, remoteAddr, s.handleLocal, multicastLoop); r != (Route{}) {
|
||||
return r, nil
|
||||
}
|
||||
}
|
||||
|
|
@ -2130,3 +2130,43 @@ func (s *Stack) networkProtocolNumbers() []tcpip.NetworkProtocolNumber {
|
|||
}
|
||||
return protos
|
||||
}
|
||||
|
||||
func isSubnetBroadcastOnNIC(nic *NIC, protocol tcpip.NetworkProtocolNumber, addr tcpip.Address) bool {
|
||||
addressEndpoint := nic.getAddressOrCreateTempInner(protocol, addr, false /* createTemp */, NeverPrimaryEndpoint)
|
||||
if addressEndpoint == nil {
|
||||
return false
|
||||
}
|
||||
|
||||
subnet := addressEndpoint.Subnet()
|
||||
addressEndpoint.DecRef()
|
||||
return subnet.IsBroadcast(addr)
|
||||
}
|
||||
|
||||
// IsSubnetBroadcast returns true if the provided address is a subnet-local
|
||||
// broadcast address on the specified NIC and protocol.
|
||||
//
|
||||
// Returns false if the NIC is unknown or if the protocol is unknown or does
|
||||
// not support addressing.
|
||||
//
|
||||
// If the NIC is not specified, the stack will check all NICs.
|
||||
func (s *Stack) IsSubnetBroadcast(nicID tcpip.NICID, protocol tcpip.NetworkProtocolNumber, addr tcpip.Address) bool {
|
||||
s.mu.RLock()
|
||||
defer s.mu.RUnlock()
|
||||
|
||||
if nicID != 0 {
|
||||
nic, ok := s.nics[nicID]
|
||||
if !ok {
|
||||
return false
|
||||
}
|
||||
|
||||
return isSubnetBroadcastOnNIC(nic, protocol, addr)
|
||||
}
|
||||
|
||||
for _, nic := range s.nics {
|
||||
if isSubnetBroadcastOnNIC(nic, protocol, addr) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
|
||||
return false
|
||||
}
|
||||
|
|
|
|||
|
|
@ -25,6 +25,7 @@ go_test(
|
|||
"//pkg/tcpip/network/ipv6",
|
||||
"//pkg/tcpip/stack",
|
||||
"//pkg/tcpip/transport/icmp",
|
||||
"//pkg/tcpip/transport/tcp",
|
||||
"//pkg/tcpip/transport/udp",
|
||||
"//pkg/waiter",
|
||||
"@com_github_google_go_cmp//cmp:go_default_library",
|
||||
|
|
|
|||
|
|
@ -26,6 +26,7 @@ import (
|
|||
"gvisor.dev/gvisor/pkg/tcpip/network/ipv4"
|
||||
"gvisor.dev/gvisor/pkg/tcpip/network/ipv6"
|
||||
"gvisor.dev/gvisor/pkg/tcpip/stack"
|
||||
"gvisor.dev/gvisor/pkg/tcpip/transport/tcp"
|
||||
"gvisor.dev/gvisor/pkg/tcpip/transport/udp"
|
||||
"gvisor.dev/gvisor/pkg/waiter"
|
||||
)
|
||||
|
|
@ -93,9 +94,10 @@ func TestInitialLoopbackAddresses(t *testing.T) {
|
|||
}
|
||||
}
|
||||
|
||||
// TestLoopbackAcceptAllInSubnet tests that a loopback interface considers
|
||||
// itself bound to all addresses in the subnet of an assigned address.
|
||||
func TestLoopbackAcceptAllInSubnet(t *testing.T) {
|
||||
// TestLoopbackAcceptAllInSubnetUDP tests that a loopback interface considers
|
||||
// itself bound to all addresses in the subnet of an assigned address and UDP
|
||||
// traffic is sent/received correctly.
|
||||
func TestLoopbackAcceptAllInSubnetUDP(t *testing.T) {
|
||||
const (
|
||||
nicID = 1
|
||||
localPort = 80
|
||||
|
|
@ -107,7 +109,7 @@ func TestLoopbackAcceptAllInSubnet(t *testing.T) {
|
|||
Protocol: header.IPv4ProtocolNumber,
|
||||
AddressWithPrefix: ipv4Addr,
|
||||
}
|
||||
ipv4Bytes := []byte(ipv4Addr.Address)
|
||||
ipv4Bytes := []byte(ipv4ProtocolAddress.AddressWithPrefix.Address)
|
||||
ipv4Bytes[len(ipv4Bytes)-1]++
|
||||
otherIPv4Address := tcpip.Address(ipv4Bytes)
|
||||
|
||||
|
|
@ -129,7 +131,7 @@ func TestLoopbackAcceptAllInSubnet(t *testing.T) {
|
|||
{
|
||||
name: "IPv4 bind to wildcard and send to assigned address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
dstAddr: ipv4Addr.Address,
|
||||
dstAddr: ipv4ProtocolAddress.AddressWithPrefix.Address,
|
||||
expectRx: true,
|
||||
},
|
||||
{
|
||||
|
|
@ -148,7 +150,7 @@ func TestLoopbackAcceptAllInSubnet(t *testing.T) {
|
|||
name: "IPv4 bind to other subnet-local address and send to assigned address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
bindAddr: otherIPv4Address,
|
||||
dstAddr: ipv4Addr.Address,
|
||||
dstAddr: ipv4ProtocolAddress.AddressWithPrefix.Address,
|
||||
expectRx: false,
|
||||
},
|
||||
{
|
||||
|
|
@ -161,7 +163,7 @@ func TestLoopbackAcceptAllInSubnet(t *testing.T) {
|
|||
{
|
||||
name: "IPv4 bind to assigned address and send to other subnet-local address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
bindAddr: ipv4Addr.Address,
|
||||
bindAddr: ipv4ProtocolAddress.AddressWithPrefix.Address,
|
||||
dstAddr: otherIPv4Address,
|
||||
expectRx: false,
|
||||
},
|
||||
|
|
@ -236,13 +238,17 @@ func TestLoopbackAcceptAllInSubnet(t *testing.T) {
|
|||
t.Fatalf("got sep.Write(_, _) = (%d, _, nil), want = (%d, _, nil)", n, want)
|
||||
}
|
||||
|
||||
if gotPayload, _, err := rep.Read(nil); test.expectRx {
|
||||
var addr tcpip.FullAddress
|
||||
if gotPayload, _, err := rep.Read(&addr); test.expectRx {
|
||||
if err != nil {
|
||||
t.Fatalf("reep.Read(nil): %s", err)
|
||||
t.Fatalf("reep.Read(_): %s", err)
|
||||
}
|
||||
if diff := cmp.Diff(buffer.View(data), gotPayload); diff != "" {
|
||||
t.Errorf("got UDP payload mismatch (-want +got):\n%s", diff)
|
||||
}
|
||||
if addr.Addr != test.addAddress.AddressWithPrefix.Address {
|
||||
t.Errorf("got addr.Addr = %s, want = %s", addr.Addr, test.addAddress.AddressWithPrefix.Address)
|
||||
}
|
||||
} else {
|
||||
if err != tcpip.ErrWouldBlock {
|
||||
t.Fatalf("got rep.Read(nil) = (%x, _, %s), want = (_, _, %s)", gotPayload, err, tcpip.ErrWouldBlock)
|
||||
|
|
@ -312,3 +318,168 @@ func TestLoopbackSubnetLifetimeBoundToAddr(t *testing.T) {
|
|||
t.Fatalf("got r.WritePacket(nil, %#v, _) = %s, want = %s", params, err, tcpip.ErrInvalidEndpointState)
|
||||
}
|
||||
}
|
||||
|
||||
// TestLoopbackAcceptAllInSubnetTCP tests that a loopback interface considers
|
||||
// itself bound to all addresses in the subnet of an assigned address and TCP
|
||||
// traffic is sent/received correctly.
|
||||
func TestLoopbackAcceptAllInSubnetTCP(t *testing.T) {
|
||||
const (
|
||||
nicID = 1
|
||||
localPort = 80
|
||||
)
|
||||
|
||||
ipv4ProtocolAddress := tcpip.ProtocolAddress{
|
||||
Protocol: header.IPv4ProtocolNumber,
|
||||
AddressWithPrefix: ipv4Addr,
|
||||
}
|
||||
ipv4ProtocolAddress.AddressWithPrefix.PrefixLen = 8
|
||||
ipv4Bytes := []byte(ipv4ProtocolAddress.AddressWithPrefix.Address)
|
||||
ipv4Bytes[len(ipv4Bytes)-1]++
|
||||
otherIPv4Address := tcpip.Address(ipv4Bytes)
|
||||
|
||||
ipv6ProtocolAddress := tcpip.ProtocolAddress{
|
||||
Protocol: header.IPv6ProtocolNumber,
|
||||
AddressWithPrefix: ipv6Addr,
|
||||
}
|
||||
ipv6Bytes := []byte(ipv6Addr.Address)
|
||||
ipv6Bytes[len(ipv6Bytes)-1]++
|
||||
otherIPv6Address := tcpip.Address(ipv6Bytes)
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
addAddress tcpip.ProtocolAddress
|
||||
bindAddr tcpip.Address
|
||||
dstAddr tcpip.Address
|
||||
expectAccept bool
|
||||
}{
|
||||
{
|
||||
name: "IPv4 bind to wildcard and send to assigned address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
dstAddr: ipv4ProtocolAddress.AddressWithPrefix.Address,
|
||||
expectAccept: true,
|
||||
},
|
||||
{
|
||||
name: "IPv4 bind to wildcard and send to other subnet-local address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
dstAddr: otherIPv4Address,
|
||||
expectAccept: true,
|
||||
},
|
||||
{
|
||||
name: "IPv4 bind to wildcard send to other address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
dstAddr: remoteIPv4Addr,
|
||||
expectAccept: false,
|
||||
},
|
||||
{
|
||||
name: "IPv4 bind to other subnet-local address and send to assigned address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
bindAddr: otherIPv4Address,
|
||||
dstAddr: ipv4ProtocolAddress.AddressWithPrefix.Address,
|
||||
expectAccept: false,
|
||||
},
|
||||
{
|
||||
name: "IPv4 bind and send to other subnet-local address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
bindAddr: otherIPv4Address,
|
||||
dstAddr: otherIPv4Address,
|
||||
expectAccept: true,
|
||||
},
|
||||
{
|
||||
name: "IPv4 bind to assigned address and send to other subnet-local address",
|
||||
addAddress: ipv4ProtocolAddress,
|
||||
bindAddr: ipv4ProtocolAddress.AddressWithPrefix.Address,
|
||||
dstAddr: otherIPv4Address,
|
||||
expectAccept: false,
|
||||
},
|
||||
|
||||
{
|
||||
name: "IPv6 bind and send to assigned address",
|
||||
addAddress: ipv6ProtocolAddress,
|
||||
bindAddr: ipv6Addr.Address,
|
||||
dstAddr: ipv6Addr.Address,
|
||||
expectAccept: true,
|
||||
},
|
||||
{
|
||||
name: "IPv6 bind to wildcard and send to other subnet-local address",
|
||||
addAddress: ipv6ProtocolAddress,
|
||||
dstAddr: otherIPv6Address,
|
||||
expectAccept: false,
|
||||
},
|
||||
}
|
||||
|
||||
for _, test := range tests {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
s := stack.New(stack.Options{
|
||||
NetworkProtocols: []stack.NetworkProtocolFactory{ipv4.NewProtocol, ipv6.NewProtocol},
|
||||
TransportProtocols: []stack.TransportProtocolFactory{tcp.NewProtocol},
|
||||
})
|
||||
if err := s.CreateNIC(nicID, loopback.New()); err != nil {
|
||||
t.Fatalf("CreateNIC(%d, _): %s", nicID, err)
|
||||
}
|
||||
if err := s.AddProtocolAddress(nicID, test.addAddress); err != nil {
|
||||
t.Fatalf("AddProtocolAddress(%d, %#v): %s", nicID, test.addAddress, err)
|
||||
}
|
||||
s.SetRouteTable([]tcpip.Route{
|
||||
tcpip.Route{
|
||||
Destination: header.IPv4EmptySubnet,
|
||||
NIC: nicID,
|
||||
},
|
||||
tcpip.Route{
|
||||
Destination: header.IPv6EmptySubnet,
|
||||
NIC: nicID,
|
||||
},
|
||||
})
|
||||
|
||||
var wq waiter.Queue
|
||||
we, ch := waiter.NewChannelEntry(nil)
|
||||
wq.EventRegister(&we, waiter.EventIn)
|
||||
defer wq.EventUnregister(&we)
|
||||
listeningEndpoint, err := s.NewEndpoint(tcp.ProtocolNumber, test.addAddress.Protocol, &wq)
|
||||
if err != nil {
|
||||
t.Fatalf("NewEndpoint(%d, %d, _): %s", udp.ProtocolNumber, test.addAddress.Protocol, err)
|
||||
}
|
||||
defer listeningEndpoint.Close()
|
||||
|
||||
bindAddr := tcpip.FullAddress{Addr: test.bindAddr, Port: localPort}
|
||||
if err := listeningEndpoint.Bind(bindAddr); err != nil {
|
||||
t.Fatalf("listeningEndpoint.Bind(%#v): %s", bindAddr, err)
|
||||
}
|
||||
|
||||
if err := listeningEndpoint.Listen(1); err != nil {
|
||||
t.Fatalf("listeningEndpoint.Listen(1): %s", err)
|
||||
}
|
||||
|
||||
connectingEndpoint, err := s.NewEndpoint(tcp.ProtocolNumber, test.addAddress.Protocol, &wq)
|
||||
if err != nil {
|
||||
t.Fatalf("s.NewEndpoint(%d, %d, _): %s", udp.ProtocolNumber, test.addAddress.Protocol, err)
|
||||
}
|
||||
defer connectingEndpoint.Close()
|
||||
|
||||
connectAddr := tcpip.FullAddress{
|
||||
Addr: test.dstAddr,
|
||||
Port: localPort,
|
||||
}
|
||||
if err := connectingEndpoint.Connect(connectAddr); err != tcpip.ErrConnectStarted {
|
||||
t.Fatalf("connectingEndpoint.Connect(%#v): %s", connectAddr, err)
|
||||
}
|
||||
|
||||
if !test.expectAccept {
|
||||
if _, _, err := listeningEndpoint.Accept(nil); err != tcpip.ErrWouldBlock {
|
||||
t.Fatalf("got listeningEndpoint.Accept(nil) = %s, want = %s", err, tcpip.ErrWouldBlock)
|
||||
}
|
||||
return
|
||||
}
|
||||
|
||||
// Wait for the listening endpoint to be "readable". That is, wait for a
|
||||
// new connection.
|
||||
<-ch
|
||||
var addr tcpip.FullAddress
|
||||
if _, _, err := listeningEndpoint.Accept(&addr); err != nil {
|
||||
t.Fatalf("listeningEndpoint.Accept(nil): %s", err)
|
||||
}
|
||||
if addr.Addr != test.addAddress.AddressWithPrefix.Address {
|
||||
t.Errorf("got addr.Addr = %s, want = %s", addr.Addr, test.addAddress.AddressWithPrefix.Address)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -369,7 +369,7 @@ func (e *endpoint) prepareForWrite(to *tcpip.FullAddress) (retry bool, err *tcpi
|
|||
// specified address is a multicast address.
|
||||
func (e *endpoint) connectRoute(nicID tcpip.NICID, addr tcpip.FullAddress, netProto tcpip.NetworkProtocolNumber) (stack.Route, tcpip.NICID, *tcpip.Error) {
|
||||
localAddr := e.ID.LocalAddress
|
||||
if isBroadcastOrMulticast(localAddr) {
|
||||
if e.isBroadcastOrMulticast(nicID, netProto, localAddr) {
|
||||
// A packet can only originate from a unicast address (i.e., an interface).
|
||||
localAddr = ""
|
||||
}
|
||||
|
|
@ -1290,7 +1290,7 @@ func (e *endpoint) bindLocked(addr tcpip.FullAddress) *tcpip.Error {
|
|||
}
|
||||
|
||||
nicID := addr.NIC
|
||||
if len(addr.Addr) != 0 && !isBroadcastOrMulticast(addr.Addr) {
|
||||
if len(addr.Addr) != 0 && !e.isBroadcastOrMulticast(addr.NIC, netProto, addr.Addr) {
|
||||
// A local unicast address was specified, verify that it's valid.
|
||||
nicID = e.stack.CheckLocalAddress(addr.NIC, netProto, addr.Addr)
|
||||
if nicID == 0 {
|
||||
|
|
@ -1531,8 +1531,8 @@ func (e *endpoint) Stats() tcpip.EndpointStats {
|
|||
// Wait implements tcpip.Endpoint.Wait.
|
||||
func (*endpoint) Wait() {}
|
||||
|
||||
func isBroadcastOrMulticast(a tcpip.Address) bool {
|
||||
return a == header.IPv4Broadcast || header.IsV4MulticastAddress(a) || header.IsV6MulticastAddress(a)
|
||||
func (e *endpoint) isBroadcastOrMulticast(nicID tcpip.NICID, netProto tcpip.NetworkProtocolNumber, addr tcpip.Address) bool {
|
||||
return addr == header.IPv4Broadcast || header.IsV4MulticastAddress(addr) || header.IsV6MulticastAddress(addr) || e.stack.IsSubnetBroadcast(nicID, netProto, addr)
|
||||
}
|
||||
|
||||
// SetOwner implements tcpip.Endpoint.SetOwner.
|
||||
|
|
|
|||
|
|
@ -118,7 +118,7 @@ func (e *endpoint) Resume(s *stack.Stack) {
|
|||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
} else if len(e.ID.LocalAddress) != 0 && !isBroadcastOrMulticast(e.ID.LocalAddress) { // stateBound
|
||||
} else if len(e.ID.LocalAddress) != 0 && !e.isBroadcastOrMulticast(e.RegisterNICID, netProto, e.ID.LocalAddress) { // stateBound
|
||||
// A local unicast address is specified, verify that it's valid.
|
||||
if e.stack.CheckLocalAddress(e.RegisterNICID, netProto, e.ID.LocalAddress) == 0 {
|
||||
panic(tcpip.ErrBadLocalAddress)
|
||||
|
|
|
|||
Loading…
Reference in New Issue