From 660a1a10283ba1c11398280fecff588d97743584 Mon Sep 17 00:00:00 2001 From: gVisor bot Date: Mon, 4 May 2020 12:47:53 -0700 Subject: [PATCH] Internal change. PiperOrigin-RevId: 309801320 --- tools/bazeldefs/defs.bzl | 1 + tools/defs.bzl | 3 ++- vdso/BUILD | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/bazeldefs/defs.bzl b/tools/bazeldefs/defs.bzl index 1a8c1d23b..620c460de 100644 --- a/tools/bazeldefs/defs.bzl +++ b/tools/bazeldefs/defs.bzl @@ -30,6 +30,7 @@ py_binary = native.py_binary py_test = native.py_test rbe_platform = native.platform rbe_toolchain = native.toolchain +vdso_linker_option = "-fuse-ld=gold " def proto_library(name, has_services = None, **kwargs): native.proto_library( diff --git a/tools/defs.bzl b/tools/defs.bzl index fb9fd4bae..41eded16d 100644 --- a/tools/defs.bzl +++ b/tools/defs.bzl @@ -7,7 +7,7 @@ change for Google-internal and bazel-compatible rules. load("//tools/go_stateify:defs.bzl", "go_stateify") load("//tools/go_marshal:defs.bzl", "go_marshal", "marshal_deps", "marshal_test_deps") -load("//tools/bazeldefs:defs.bzl", _build_test = "build_test", _cc_binary = "cc_binary", _cc_flags_supplier = "cc_flags_supplier", _cc_grpc_library = "cc_grpc_library", _cc_library = "cc_library", _cc_proto_library = "cc_proto_library", _cc_test = "cc_test", _cc_toolchain = "cc_toolchain", _default_installer = "default_installer", _default_net_util = "default_net_util", _gazelle = "gazelle", _gbenchmark = "gbenchmark", _go_binary = "go_binary", _go_embed_data = "go_embed_data", _go_grpc_and_proto_libraries = "go_grpc_and_proto_libraries", _go_library = "go_library", _go_path = "go_path", _go_proto_library = "go_proto_library", _go_test = "go_test", _grpcpp = "grpcpp", _gtest = "gtest", _loopback = "loopback", _pkg_deb = "pkg_deb", _pkg_tar = "pkg_tar", _proto_library = "proto_library", _py_binary = "py_binary", _py_library = "py_library", _py_requirement = "py_requirement", _py_test = "py_test", _rbe_platform = "rbe_platform", _rbe_toolchain = "rbe_toolchain", _select_arch = "select_arch", _select_system = "select_system") +load("//tools/bazeldefs:defs.bzl", _build_test = "build_test", _cc_binary = "cc_binary", _cc_flags_supplier = "cc_flags_supplier", _cc_grpc_library = "cc_grpc_library", _cc_library = "cc_library", _cc_proto_library = "cc_proto_library", _cc_test = "cc_test", _cc_toolchain = "cc_toolchain", _default_installer = "default_installer", _default_net_util = "default_net_util", _gazelle = "gazelle", _gbenchmark = "gbenchmark", _go_binary = "go_binary", _go_embed_data = "go_embed_data", _go_grpc_and_proto_libraries = "go_grpc_and_proto_libraries", _go_library = "go_library", _go_path = "go_path", _go_proto_library = "go_proto_library", _go_test = "go_test", _grpcpp = "grpcpp", _gtest = "gtest", _loopback = "loopback", _pkg_deb = "pkg_deb", _pkg_tar = "pkg_tar", _proto_library = "proto_library", _py_binary = "py_binary", _py_library = "py_library", _py_requirement = "py_requirement", _py_test = "py_test", _rbe_platform = "rbe_platform", _rbe_toolchain = "rbe_toolchain", _select_arch = "select_arch", _select_system = "select_system", _vdso_linker_option = "vdso_linker_option") load("//tools/bazeldefs:platforms.bzl", _default_platform = "default_platform", _platforms = "platforms") load("//tools/bazeldefs:tags.bzl", "go_suffixes") load("//tools/nogo:defs.bzl", "nogo_test") @@ -40,6 +40,7 @@ select_arch = _select_arch select_system = _select_system rbe_platform = _rbe_platform rbe_toolchain = _rbe_toolchain +vdso_linker_option = _vdso_linker_option # Platform options. default_platform = _default_platform diff --git a/vdso/BUILD b/vdso/BUILD index d37d4266d..c70bb8218 100644 --- a/vdso/BUILD +++ b/vdso/BUILD @@ -3,7 +3,7 @@ # normal system VDSO (time, gettimeofday, clock_gettimeofday) but which uses # timekeeping parameters managed by the sandbox kernel. -load("//tools:defs.bzl", "cc_flags_supplier", "cc_toolchain", "select_arch") +load("//tools:defs.bzl", "cc_flags_supplier", "cc_toolchain", "select_arch", "vdso_linker_option") package(licenses = ["notice"]) @@ -33,7 +33,7 @@ genrule( # Some toolchains enable stack protector by default. Disable it, the # VDSO has no hooks to handle failures. "-fno-stack-protector " + - "-fuse-ld=gold " + + vdso_linker_option + select_arch( amd64 = "-m64 ", arm64 = "",