From 6bf7d0514be98b6df51436d9a23943e3cc2fdf69 Mon Sep 17 00:00:00 2001
From: Chong Cai <chongc@google.com>
Date: Wed, 28 Jul 2021 14:01:12 -0700
Subject: [PATCH] Add verity read benchmark tests

PiperOrigin-RevId: 387431049
---
 test/perf/BUILD                          |  7 +++
 test/perf/linux/BUILD                    | 19 +++++++
 test/perf/linux/verity_open_benchmark.cc |  2 -
 test/perf/linux/verity_read_benchmark.cc | 69 ++++++++++++++++++++++++
 4 files changed, 95 insertions(+), 2 deletions(-)
 create mode 100644 test/perf/linux/verity_read_benchmark.cc

diff --git a/test/perf/BUILD b/test/perf/BUILD
index 97ca0e75a..8ac63f11b 100644
--- a/test/perf/BUILD
+++ b/test/perf/BUILD
@@ -146,3 +146,10 @@ syscall_test(
     test = "//test/perf/linux:verity_open_benchmark",
     vfs1 = False,
 )
+
+syscall_test(
+    size = "large",
+    debug = False,
+    test = "//test/perf/linux:verity_read_benchmark",
+    vfs1 = False,
+)
diff --git a/test/perf/linux/BUILD b/test/perf/linux/BUILD
index b4f192227..50dd8e808 100644
--- a/test/perf/linux/BUILD
+++ b/test/perf/linux/BUILD
@@ -389,3 +389,22 @@ cc_binary(
         "//test/util:verity_util",
     ],
 )
+
+cc_binary(
+    name = "verity_read_benchmark",
+    testonly = 1,
+    srcs = [
+        "verity_read_benchmark.cc",
+    ],
+    deps = [
+        gbenchmark,
+        gtest,
+        "//test/util:capability_util",
+        "//test/util:fs_util",
+        "//test/util:logging",
+        "//test/util:temp_path",
+        "//test/util:test_main",
+        "//test/util:test_util",
+        "//test/util:verity_util",
+    ],
+)
diff --git a/test/perf/linux/verity_open_benchmark.cc b/test/perf/linux/verity_open_benchmark.cc
index ce53a2100..026b6f101 100644
--- a/test/perf/linux/verity_open_benchmark.cc
+++ b/test/perf/linux/verity_open_benchmark.cc
@@ -36,8 +36,6 @@ namespace testing {
 namespace {
 
 void BM_Open(benchmark::State& state) {
-  SKIP_IF(IsRunningWithVFS1());
-
   const int size = state.range(0);
   std::vector<TempPath> cache;
   std::vector<EnableTarget> targets;
diff --git a/test/perf/linux/verity_read_benchmark.cc b/test/perf/linux/verity_read_benchmark.cc
new file mode 100644
index 000000000..738b5ba45
--- /dev/null
+++ b/test/perf/linux/verity_read_benchmark.cc
@@ -0,0 +1,69 @@
+// Copyright 2021 The gVisor Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <fcntl.h>
+#include <stdlib.h>
+#include <sys/mount.h>
+#include <unistd.h>
+
+#include <memory>
+#include <string>
+#include <vector>
+
+#include "gtest/gtest.h"
+#include "benchmark/benchmark.h"
+#include "test/util/capability_util.h"
+#include "test/util/fs_util.h"
+#include "test/util/logging.h"
+#include "test/util/temp_path.h"
+#include "test/util/test_util.h"
+#include "test/util/verity_util.h"
+
+namespace gvisor {
+namespace testing {
+
+namespace {
+
+void BM_VerityRead(benchmark::State& state) {
+  const int size = state.range(0);
+  const std::string contents(size, 0);
+
+  // Mount a tmpfs file system to be wrapped by a verity fs.
+  TempPath dir = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateDir());
+  TEST_CHECK(mount("", dir.path().c_str(), "tmpfs", 0, "") == 0);
+
+  auto path = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFileWith(
+      dir.path(), contents, TempPath::kDefaultFileMode));
+  std::string filename = std::string(Basename(path.path()));
+
+  std::string verity_dir = TEST_CHECK_NO_ERRNO_AND_VALUE(
+      MountVerity(dir.path(), {EnableTarget(filename, O_RDONLY)}));
+
+  FileDescriptor fd =
+      ASSERT_NO_ERRNO_AND_VALUE(Open(JoinPath(verity_dir, filename), O_RDONLY));
+  std::vector<char> buf(size);
+  for (auto _ : state) {
+    TEST_CHECK(PreadFd(fd.get(), buf.data(), buf.size(), 0) == size);
+  }
+
+  state.SetBytesProcessed(static_cast<int64_t>(size) *
+                          static_cast<int64_t>(state.iterations()));
+}
+
+BENCHMARK(BM_VerityRead)->Range(1, 1 << 26)->UseRealTime();
+
+}  // namespace
+
+}  // namespace testing
+}  // namespace gvisor