go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add O_TRUNC handling in openat 

PiperOrigin-RevId: 200103677
Change-Id: I3efb565c30c64d35f8fd7b5c05ed78dcc2990c51
This commit is contained in:
Fabricio Voznika 2018-06-11 13:34:27 -07:00 committed by Shentubot
parent 032b0398a5
commit 7260363751
1 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
pkg/sentry/syscalls/linux/sys_file.go
View File

@ -147,21 +147,25 @@ func openAt(t *kernel.Task, dirFD kdefs.FD, addr usermem.Addr, flags uint) (fd u
}
fileFlags := linuxToFlags(flags)
isDir := fs.IsDir(d.Inode.StableAttr)
// If O_DIRECTORY is set, but the file is not a directory, then fail.
if fileFlags.Directory && !isDir {
return syserror.ENOTDIR
}
// If it's a directory, then make sure.
if dirPath && !isDir {
return syserror.ENOTDIR
}
// Don't allow directories to be opened writable.
if isDir && fileFlags.Write {
return syserror.EISDIR
if fs.IsDir(d.Inode.StableAttr) {
// Don't allow directories to be opened writable.
if fileFlags.Write {
return syserror.EISDIR
}
} else {
// If O_DIRECTORY is set, but the file is not a directory, then fail.
if fileFlags.Directory {
return syserror.ENOTDIR
}
// If it's a directory, then make sure.
if dirPath {
return syserror.ENOTDIR
}
if fileFlags.Write && flags&syscall.O_TRUNC != 0 {
if err := d.Inode.Truncate(t, d, 0); err != nil {
return err
}
}
}
file, err := d.Inode.GetFile(t, d, fileFlags)