From ae6e37df2abe450b30aba0908c212e9a1f81b84a Mon Sep 17 00:00:00 2001 From: Zhaozhong Ni Date: Mon, 28 Jan 2019 15:33:09 -0800 Subject: [PATCH] Convert TODO into FIXME. PiperOrigin-RevId: 231301228 Change-Id: I3e18f3a12a35fb89a22a8c981188268d5887dc61 --- pkg/sentry/fs/proc/task.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/sentry/fs/proc/task.go b/pkg/sentry/fs/proc/task.go index 41981a973..70578d3fa 100644 --- a/pkg/sentry/fs/proc/task.go +++ b/pkg/sentry/fs/proc/task.go @@ -76,9 +76,7 @@ func newTaskDir(t *kernel.Task, msrc *fs.MountSource, pidns *kernel.PIDNamespace "fd": newFdDir(t, msrc), "fdinfo": newFdInfoDir(t, msrc), "gid_map": newGIDMap(t, msrc), - // TODO: This is incorrect for /proc/[pid]/task/[tid]/io, i.e. if - // showSubtasks is false: - // https://elixir.bootlin.com/linux/v4.4/source/fs/proc/base.c#L3154 + // FIXME: create the correct io file for threads. "io": newIO(t, msrc), "maps": newMaps(t, msrc), "mountinfo": seqfile.NewSeqFileInode(t, &mountInfoFile{t: t}, msrc),