go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Drop reference on fs.Inode if Mount goes wrong. 

PiperOrigin-RevId: 261203674
This commit is contained in:
Nicolas Lacasse 2019-08-01 14:56:29 -07:00 committed by gVisor bot
parent f2b25aeac7
commit bad43772a1
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/sentry/syscalls/linux/sys_mount.go
View File

@ -109,9 +109,17 @@ func Mount(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall
return 0, nil, syserror.EINVAL
}
return 0, nil, fileOpOn(t, linux.AT_FDCWD, targetPath, true /* resolve */, func(root *fs.Dirent, d *fs.Dirent, _ uint) error {
if err := fileOpOn(t, linux.AT_FDCWD, targetPath, true /* resolve */, func(root *fs.Dirent, d *fs.Dirent, _ uint) error {
// Mount will take a reference on rootInode if successful.
return t.MountNamespace().Mount(t, d, rootInode)
})
}); err != nil {
// Something went wrong. Drop our ref on rootInode before
// returning the error.
rootInode.DecRef()
return 0, nil, err
}
return 0, nil, nil
}
// Umount2 implements Linux syscall umount2(2).