go
/
gvisor
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use syscall() for fchmod() calls 

Avoids Bionic when running on Android.
See https://android-review.googlesource.com/c/platform/bionic/+/127908

PiperOrigin-RevId: 448378850
This commit is contained in:
gVisor bot 2022-05-12 17:46:13 -07:00
parent 700014c960
commit d4652bd6df
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/syscalls/linux/chmod.cc
View File

@ -14,6 +14,7 @@
#include <fcntl.h>
#include <sys/stat.h>
#include <sys/syscall.h>
#include <sys/types.h>
#include <unistd.h>
@ -102,7 +103,11 @@ TEST(ChmodTest, FchmodFileWithOpath) {
auto file = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFile());
FileDescriptor fd = ASSERT_NO_ERRNO_AND_VALUE(Open(file.path(), O_PATH));
ASSERT_THAT(fchmod(fd.get(), 0444), SyscallFailsWithErrno(EBADF));
// Bionic's implementation of fchmod() uses chmod() when O_PATH is set
// to circumvent the behavior this is testing for.
// Use syscall() here to avoid running through Bionic on Android.
ASSERT_THAT(syscall(SYS_fchmod, fd.get(), 0444),
SyscallFailsWithErrno(EBADF));
}
TEST(ChmodTest, FchmodDirWithOpath) {
@ -110,7 +115,8 @@ TEST(ChmodTest, FchmodDirWithOpath) {
const auto fd =
ASSERT_NO_ERRNO_AND_VALUE(Open(dir.path(), O_DIRECTORY | O_PATH));
ASSERT_THAT(fchmod(fd.get(), 0444), SyscallFailsWithErrno(EBADF));
ASSERT_THAT(syscall(SYS_fchmod, fd.get(), 0444),
SyscallFailsWithErrno(EBADF));
}
TEST(ChmodTest, FchmodatWithOpath) {