// Copyright 2018 The gVisor Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package fdpipe import ( "bytes" "io" "os" "syscall" "testing" "gvisor.googlesource.com/gvisor/pkg/fd" "gvisor.googlesource.com/gvisor/pkg/fdnotifier" "gvisor.googlesource.com/gvisor/pkg/sentry/context/contexttest" "gvisor.googlesource.com/gvisor/pkg/sentry/fs" "gvisor.googlesource.com/gvisor/pkg/sentry/usermem" "gvisor.googlesource.com/gvisor/pkg/syserror" ) func singlePipeFD() (int, error) { fds := make([]int, 2) if err := syscall.Pipe(fds); err != nil { return -1, err } syscall.Close(fds[1]) return fds[0], nil } func singleDirFD() (int, error) { return syscall.Open(os.TempDir(), syscall.O_RDONLY, 0666) } func mockPipeDirent(t *testing.T) *fs.Dirent { ctx := contexttest.Context(t) node := fs.NewMockInodeOperations(ctx) node.UAttr = fs.UnstableAttr{ Perms: fs.FilePermissions{ User: fs.PermMask{Read: true, Write: true}, }, } inode := fs.NewInode(node, fs.NewMockMountSource(nil), fs.StableAttr{ Type: fs.Pipe, BlockSize: usermem.PageSize, }) return fs.NewDirent(inode, "") } func TestNewPipe(t *testing.T) { for _, test := range []struct { // desc is the test's description. desc string // getfd generates the fd to pass to newPipeOperations. getfd func() (int, error) // flags are the fs.FileFlags passed to newPipeOperations. flags fs.FileFlags // readAheadBuffer is the buffer passed to newPipeOperations. readAheadBuffer []byte // err is the expected error. err error }{ { desc: "Cannot make new pipe from bad fd", getfd: func() (int, error) { return -1, nil }, err: syscall.EINVAL, }, { desc: "Cannot make new pipe from non-pipe fd", getfd: singleDirFD, err: syscall.EINVAL, }, { desc: "Can make new pipe from pipe fd", getfd: singlePipeFD, flags: fs.FileFlags{Read: true}, readAheadBuffer: []byte("hello"), }, } { gfd, err := test.getfd() if err != nil { t.Errorf("%s: getfd got (%d, %v), want (fd, nil)", test.desc, gfd, err) continue } f := fd.New(gfd) p, err := newPipeOperations(contexttest.Context(t), nil, test.flags, f, test.readAheadBuffer) if p != nil { // This is necessary to remove the fd from the global fd notifier. defer p.Release() } else { // If there is no p to DecRef on, because newPipeOperations failed, then the // file still needs to be closed. defer f.Close() } if err != test.err { t.Errorf("%s: got error %v, want %v", test.desc, err, test.err) continue } // Check the state of the pipe given that it was successfully opened. if err == nil { if p == nil { t.Errorf("%s: got nil pipe and nil error, want (pipe, nil)", test.desc) continue } if flags := p.flags; test.flags != flags { t.Errorf("%s: got file flags %s, want %s", test.desc, flags, test.flags) continue } if len(test.readAheadBuffer) != len(p.readAheadBuffer) { t.Errorf("%s: got read ahead buffer length %d, want %d", test.desc, len(p.readAheadBuffer), len(test.readAheadBuffer)) continue } fileFlags, _, errno := syscall.Syscall(syscall.SYS_FCNTL, uintptr(p.file.FD()), syscall.F_GETFL, 0) if errno != 0 { t.Errorf("%s: failed to get file flags for fd %d, got %v, want 0", test.desc, p.file.FD(), errno) continue } if fileFlags&syscall.O_NONBLOCK == 0 { t.Errorf("%s: pipe is blocking, expected non-blocking", test.desc) continue } if !fdnotifier.HasFD(int32(f.FD())) { t.Errorf("%s: pipe fd %d is not registered for events", test.desc, f.FD) } } } } func TestPipeDestruction(t *testing.T) { fds := make([]int, 2) if err := syscall.Pipe(fds); err != nil { t.Fatalf("failed to create pipes: got %v, want nil", err) } f := fd.New(fds[0]) // We don't care about the other end, just use the read end. syscall.Close(fds[1]) // Test the read end, but it doesn't really matter which. p, err := newPipeOperations(contexttest.Context(t), nil, fs.FileFlags{Read: true}, f, nil) if err != nil { f.Close() t.Fatalf("newPipeOperations got error %v, want nil", err) } // Drop our only reference, which should trigger the destructor. p.Release() if fdnotifier.HasFD(int32(fds[0])) { t.Fatalf("after DecRef fdnotifier has fd %d, want no longer registered", fds[0]) } if p.file != nil { t.Errorf("after DecRef got file, want nil") } } type Seek struct{} type ReadDir struct{} type Writev struct { Src usermem.IOSequence } type Readv struct { Dst usermem.IOSequence } type Fsync struct{} func TestPipeRequest(t *testing.T) { for _, test := range []struct { // desc is the test's description. desc string // request to execute. context interface{} // flags determines whether to use the read or write end // of the pipe, for this test it can only be Read or Write. flags fs.FileFlags // keepOpenPartner if false closes the other end of the pipe, // otherwise this is delayed until the end of the test. keepOpenPartner bool // expected error err error }{ { desc: "ReadDir on pipe returns ENOTDIR", context: &ReadDir{}, err: syscall.ENOTDIR, }, { desc: "Fsync on pipe returns EINVAL", context: &Fsync{}, err: syscall.EINVAL, }, { desc: "Seek on pipe returns ESPIPE", context: &Seek{}, err: syscall.ESPIPE, }, { desc: "Readv on pipe from empty buffer returns nil", context: &Readv{Dst: usermem.BytesIOSequence(nil)}, flags: fs.FileFlags{Read: true}, }, { desc: "Readv on pipe from non-empty buffer and closed partner returns EOF", context: &Readv{Dst: usermem.BytesIOSequence(make([]byte, 10))}, flags: fs.FileFlags{Read: true}, err: io.EOF, }, { desc: "Readv on pipe from non-empty buffer and open partner returns EWOULDBLOCK", context: &Readv{Dst: usermem.BytesIOSequence(make([]byte, 10))}, flags: fs.FileFlags{Read: true}, keepOpenPartner: true, err: syserror.ErrWouldBlock, }, { desc: "Writev on pipe from empty buffer returns nil", context: &Writev{Src: usermem.BytesIOSequence(nil)}, flags: fs.FileFlags{Write: true}, }, { desc: "Writev on pipe from non-empty buffer and closed partner returns EPIPE", context: &Writev{Src: usermem.BytesIOSequence([]byte("hello"))}, flags: fs.FileFlags{Write: true}, err: syscall.EPIPE, }, { desc: "Writev on pipe from non-empty buffer and open partner succeeds", context: &Writev{Src: usermem.BytesIOSequence([]byte("hello"))}, flags: fs.FileFlags{Write: true}, keepOpenPartner: true, }, } { if test.flags.Read && test.flags.Write { panic("both read and write not supported for this test") } fds := make([]int, 2) if err := syscall.Pipe(fds); err != nil { t.Errorf("%s: failed to create pipes: got %v, want nil", test.desc, err) continue } // Configure the fd and partner fd based on the file flags. testFd, partnerFd := fds[0], fds[1] if test.flags.Write { testFd, partnerFd = fds[1], fds[0] } // Configure closing the fds. if test.keepOpenPartner { defer syscall.Close(partnerFd) } else { syscall.Close(partnerFd) } // Create the pipe. ctx := contexttest.Context(t) p, err := newPipeOperations(ctx, nil, test.flags, fd.New(testFd), nil) if err != nil { t.Fatalf("%s: newPipeOperations got error %v, want nil", test.desc, err) } defer p.Release() inode := fs.NewMockInode(ctx, fs.NewMockMountSource(nil), fs.StableAttr{Type: fs.Pipe}) file := fs.NewFile(ctx, fs.NewDirent(inode, "pipe"), fs.FileFlags{Read: true}, p) // Issue request via the appropriate function. switch c := test.context.(type) { case *Seek: _, err = p.Seek(ctx, file, 0, 0) case *ReadDir: _, err = p.Readdir(ctx, file, nil) case *Readv: _, err = p.Read(ctx, file, c.Dst, 0) case *Writev: _, err = p.Write(ctx, file, c.Src, 0) case *Fsync: err = p.Fsync(ctx, file, 0, fs.FileMaxOffset, fs.SyncAll) default: t.Errorf("%s: unknown request type %T", test.desc, test.context) } if unwrapError(err) != test.err { t.Errorf("%s: got error %v, want %v", test.desc, err, test.err) } } } func TestPipeReadAheadBuffer(t *testing.T) { fds := make([]int, 2) if err := syscall.Pipe(fds); err != nil { t.Fatalf("failed to create pipes: got %v, want nil", err) } rfile := fd.New(fds[0]) // Eventually close the write end, which is not wrapped in a pipe object. defer syscall.Close(fds[1]) // Write some bytes to this end. data := []byte("world") if n, err := syscall.Write(fds[1], data); n != len(data) || err != nil { rfile.Close() t.Fatalf("write to pipe got (%d, %v), want (%d, nil)", n, err, len(data)) } // Close the write end immediately, we don't care about it. buffered := []byte("hello ") ctx := contexttest.Context(t) p, err := newPipeOperations(ctx, nil, fs.FileFlags{Read: true}, rfile, buffered) if err != nil { rfile.Close() t.Fatalf("newPipeOperations got error %v, want nil", err) } defer p.Release() inode := fs.NewMockInode(ctx, fs.NewMockMountSource(nil), fs.StableAttr{ Type: fs.Pipe, }) file := fs.NewFile(ctx, fs.NewDirent(inode, "pipe"), fs.FileFlags{Read: true}, p) // In total we expect to read data + buffered. total := append(buffered, data...) buf := make([]byte, len(total)) iov := usermem.BytesIOSequence(buf) n, err := p.Read(contexttest.Context(t), file, iov, 0) if err != nil { t.Fatalf("read request got error %v, want nil", err) } if n != int64(len(total)) { t.Fatalf("read request got %d bytes, want %d", n, len(total)) } if !bytes.Equal(buf, total) { t.Errorf("read request got bytes [%v], want [%v]", buf, total) } } // This is very important for pipes in general because they can return EWOULDBLOCK and for // those that block they must continue until they have read all of the data (and report it // as such. func TestPipeReadsAccumulate(t *testing.T) { fds := make([]int, 2) if err := syscall.Pipe(fds); err != nil { t.Fatalf("failed to create pipes: got %v, want nil", err) } rfile := fd.New(fds[0]) // Eventually close the write end, it doesn't depend on a pipe object. defer syscall.Close(fds[1]) // Get a new read only pipe reference. ctx := contexttest.Context(t) p, err := newPipeOperations(ctx, nil, fs.FileFlags{Read: true}, rfile, nil) if err != nil { rfile.Close() t.Fatalf("newPipeOperations got error %v, want nil", err) } // Don't forget to remove the fd from the fd notifier. Otherwise other tests will // likely be borked, because it's global :( defer p.Release() inode := fs.NewMockInode(ctx, fs.NewMockMountSource(nil), fs.StableAttr{ Type: fs.Pipe, }) file := fs.NewFile(ctx, fs.NewDirent(inode, "pipe"), fs.FileFlags{Read: true}, p) // Write some some bytes to the pipe. data := []byte("some message") if n, err := syscall.Write(fds[1], data); n != len(data) || err != nil { t.Fatalf("write to pipe got (%d, %v), want (%d, nil)", n, err, len(data)) } // Construct a segment vec that is a bit more than we have written so we trigger // an EWOULDBLOCK. wantBytes := len(data) + 1 readBuffer := make([]byte, wantBytes) iov := usermem.BytesIOSequence(readBuffer) n, err := p.Read(ctx, file, iov, 0) total := n iov = iov.DropFirst64(n) if err != syserror.ErrWouldBlock { t.Fatalf("Readv got error %v, want %v", err, syserror.ErrWouldBlock) } // Write a few more bytes to allow us to read more/accumulate. extra := []byte("extra") if n, err := syscall.Write(fds[1], extra); n != len(extra) || err != nil { t.Fatalf("write to pipe got (%d, %v), want (%d, nil)", n, err, len(extra)) } // This time, using the same request, we should not block. n, err = p.Read(ctx, file, iov, 0) total += n if err != nil { t.Fatalf("Readv got error %v, want nil", err) } // Assert that the result we got back is cumulative. if total != int64(wantBytes) { t.Fatalf("Readv sequence got %d bytes, want %d", total, wantBytes) } if want := append(data, extra[0]); !bytes.Equal(readBuffer, want) { t.Errorf("Readv sequence got %v, want %v", readBuffer, want) } } // Same as TestReadsAccumulate. func TestPipeWritesAccumulate(t *testing.T) { fds := make([]int, 2) if err := syscall.Pipe(fds); err != nil { t.Fatalf("failed to create pipes: got %v, want nil", err) } wfile := fd.New(fds[1]) // Eventually close the read end, it doesn't depend on a pipe object. defer syscall.Close(fds[0]) // Get a new write only pipe reference. ctx := contexttest.Context(t) p, err := newPipeOperations(ctx, nil, fs.FileFlags{Write: true}, wfile, nil) if err != nil { wfile.Close() t.Fatalf("newPipeOperations got error %v, want nil", err) } // Don't forget to remove the fd from the fd notifier. Otherwise other tests will // likely be borked, because it's global :( defer p.Release() inode := fs.NewMockInode(ctx, fs.NewMockMountSource(nil), fs.StableAttr{ Type: fs.Pipe, }) file := fs.NewFile(ctx, fs.NewDirent(inode, "pipe"), fs.FileFlags{Read: true}, p) // Construct a segment vec that is larger than the pipe size to trigger an EWOULDBLOCK. wantBytes := 65536 * 2 writeBuffer := make([]byte, wantBytes) for i := 0; i < wantBytes; i++ { writeBuffer[i] = 'a' } iov := usermem.BytesIOSequence(writeBuffer) n, err := p.Write(ctx, file, iov, 0) total := n iov = iov.DropFirst64(n) if err != syserror.ErrWouldBlock { t.Fatalf("Writev got error %v, want %v", err, syserror.ErrWouldBlock) } // Read the entire pipe buf size to make space for the second half. throwAway := make([]byte, 65536) if n, err := syscall.Read(fds[0], throwAway); n != len(throwAway) || err != nil { t.Fatalf("write to pipe got (%d, %v), want (%d, nil)", n, err, len(throwAway)) } // This time we should not block. n, err = p.Write(ctx, file, iov, 0) total += n if err != nil { t.Fatalf("Writev got error %v, want nil", err) } // Assert that the result we got back is cumulative. if total != int64(wantBytes) { t.Fatalf("Writev sequence got %d bytes, want %d", total, wantBytes) } }