Commit Graph

8539 Commits

Author SHA1 Message Date
gVisor bot fe9e366220 Merge release-20210322.0-48-g661e5ae7a (automated) 2021-04-06 00:14:11 +00:00
Fabricio Voznika 661e5ae7ae Enable Checkpoint/Restore test with VFS2
Closes #3373

PiperOrigin-RevId: 366903991
2021-04-05 17:10:01 -07:00
gVisor bot cfcd9d8d8b Merge release-20210322.0-47-g198e0dcde (automated) 2021-04-06 00:04:34 +00:00
Fabricio Voznika 198e0dcde2 Add fsstress on tmpfs to presubmit
Updates #5273

PiperOrigin-RevId: 366902314
2021-04-05 17:00:25 -07:00
gVisor bot ffea7d6cbe Merge release-20210322.0-46-g88f198c2a (automated) 2021-04-05 23:10:22 +00:00
Rahat Mahmood 88f198c2a9 Allow default control values to be set for cgroupfs.
PiperOrigin-RevId: 366891806
2021-04-05 16:06:11 -07:00
Ayush Ranjan 2d9095c7a6 Actually don't run unlink_benchmark with TSAN.
This benchmark currently takes > 15 minutes to run in that case.

PiperOrigin-RevId: 366891726
2021-04-05 16:01:39 -07:00
gVisor bot af8254b215 Merge release-20210322.0-44-ge7b202364 (automated) 2021-04-05 19:42:41 +00:00
Kevin Krakauer e7b2023647 deflake semaphore test
There's no reason to actually increment the semaphore, it just introduces the
chance of a race.

PiperOrigin-RevId: 366851795
2021-04-05 12:37:31 -07:00
gVisor bot 9fb1436a3e Merge release-20210322.0-43-ge21a71bff (automated) 2021-04-05 19:06:01 +00:00
Chong Cai e21a71bff1 Allow user mount for verity fs
Allow user mounting a verity fs on an existing mount by specifying mount
flags root_hash and lower_path.

PiperOrigin-RevId: 366843846
2021-04-05 12:01:44 -07:00
Chong Cai 58afd120d3 Set Verity bit in verity_prepare cmd
This is needed to enable Xattrs features required by verity.

PiperOrigin-RevId: 366843640
2021-04-05 11:56:59 -07:00
gVisor bot f559eb566c Merge release-20210322.0-41-g3007ae647 (automated) 2021-04-05 18:44:00 +00:00
Fabricio Voznika 3007ae647d Fail tests when container returns non-zero status
PiperOrigin-RevId: 366839955
2021-04-05 11:39:53 -07:00
gVisor bot f8cb9b55f4 Merge release-20210322.0-40-g8161ed411 (automated) 2021-04-05 17:03:42 +00:00
Adin Scannell 8161ed4110 Don't run unlink_benchmark with TSAN.
This benchmark currently takes > 15 minutes to run in that case.

PiperOrigin-RevId: 366817185
2021-04-05 09:57:35 -07:00
gVisor bot 001577c29b Merge release-20210322.0-39-g9a8692c82 (automated) 2021-04-03 07:22:42 +00:00
Adin Scannell 9a8692c82a Remove eternal and enormous tests.
PiperOrigin-RevId: 366573366
2021-04-03 00:18:34 -07:00
gVisor bot 0e1d141ffc Merge release-20210322.0-38-g932c8abd0 (automated) 2021-04-03 04:15:14 +00:00
Rahat Mahmood 932c8abd0f Implement cgroupfs.
A skeleton implementation of cgroupfs. It supports trivial cpu and
memory controllers with no support for hierarchies.

PiperOrigin-RevId: 366561126
2021-04-02 21:10:44 -07:00
gVisor bot 3dee9c5734 Merge release-20210322.0-37-ga0c167447 (automated) 2021-04-03 03:06:39 +00:00
gVisor bot a0c1674478 Internal change.
PiperOrigin-RevId: 366555466
2021-04-02 20:02:26 -07:00
gVisor bot 851ddb1003 Merge release-20210322.0-36-g491b106d6 (automated) 2021-04-03 02:39:12 +00:00
Rahat Mahmood 491b106d62 Implement the runsc verity-prepare command.
Implement a new runsc command to set up a sandbox with verityfs and
run the measure tool. This is loosely forked from the do command, and
currently requires the caller to provide the measure tool binary.

PiperOrigin-RevId: 366553769
2021-04-02 19:34:50 -07:00
gVisor bot d70f6e164f Merge release-20210322.0-35-g1b53550e5 (automated) 2021-04-02 17:46:14 +00:00
Zach Koopmans 1b53550e55 Add vfs1 to go/runsc-benchmarks
PiperOrigin-RevId: 366470480
2021-04-02 10:41:23 -07:00
gVisor bot 763255046d Merge release-20210322.0-34-gcc762235c (automated) 2021-04-02 17:02:31 +00:00
gVisor bot cc762235ce Internal change.
PiperOrigin-RevId: 366462448
2021-04-02 09:58:19 -07:00
gVisor bot 43ba8af786 Merge release-20210322.0-33-gb2ea37401 (automated) 2021-04-01 22:50:35 +00:00
gVisor bot 5f74a16e9c Merge release-20210322.0-32-g513de4039 (automated) 2021-04-01 22:44:51 +00:00
Bhasker Hariharan b2ea37401e Internal changes
PiperOrigin-RevId: 366344805
2021-04-01 15:40:07 -07:00
Adin Scannell 513de4039c Remove invalid dependency.
PiperOrigin-RevId: 366344222
2021-04-01 15:34:56 -07:00
gVisor bot 8887dbcc1d Merge release-20210322.0-31-g6c10c772e (automated) 2021-04-01 18:28:09 +00:00
gVisor bot 6c10c772e4 Internal change.
PiperOrigin-RevId: 366292533
2021-04-01 11:24:04 -07:00
gVisor bot 3edf00261b Merge release-20210322.0-30-g71f3dccbb (automated) 2021-03-30 18:42:04 +00:00
Fabricio Voznika 71f3dccbb3 Fix panic when overriding /dev files with VFS2
VFS1 skips over mounts that overrides files in /dev because the list of
files is hardcoded. This is not needed for VFS2 and a recent change
lifted this restriction. However, parts of the code were still skipping
/dev mounts even in VFS2, causing the loader to panic when it ran short
of FDs to connect to the gofer.

PiperOrigin-RevId: 365858436
2021-03-30 11:36:55 -07:00
gVisor bot 08cc017c08 Merge release-20210322.0-29-g8a2f7e716 (automated) 2021-03-29 20:35:44 +00:00
Zach Koopmans 8a2f7e716d [syserror] Split usermem package
Split usermem package to help remove syserror dependency in go_marshal.
New hostarch package contains code not dependent on syserror.

PiperOrigin-RevId: 365651233
2021-03-29 13:30:21 -07:00
gVisor bot 6a42275560 Merge release-20210322.0-28-gb125afba4 (automated) 2021-03-29 18:03:29 +00:00
gVisor bot b125afba41 Merge pull request #5728 from zhlhahaha:2091
PiperOrigin-RevId: 365613394
2021-03-29 10:57:46 -07:00
Ayush Ranjan da6ddd1df8 [perf] Reduce contention in ptrace.threadPool.lookupOrCreate().
lookupOrCreate is called from subprocess.switchToApp() and subprocess.syscall().
lookupOrCreate() looks for a thread already created for the current TID. If a
thread exists (common case), it returns immediately. Otherwise it creates a new
one.

This change switches to using a sync.RWMutex. The initial thread existence
lookup is now done only with the read lock. So multiple successful lookups can
occur concurrently. Only when a new thread is created will it acquire the lock
for writing and update the map (which is not the common case).

Discovered in mutex profiles from the various ptrace benchmarks.
Example: https://gvisor.dev/profile/gvisor-buildkite/fd14bfad-b30f-44dc-859b-80ebac50beb4/843827db-da50-4dc9-a2ea-ecf734dde2d5/tmp/profile/ptrace/BenchmarkFio/operation.write/blockSize.4K/filesystem.tmpfs/benchmarks/fio/mutex.pprof/flamegraph
PiperOrigin-RevId: 365612094
2021-03-29 10:52:19 -07:00
gVisor bot 9cecf76d42 Merge release-20210315.0-28-gfbec65fc3 (automated) 2021-03-26 03:32:34 +00:00
Jamie Liu fbec65fc3f Use seqfile.SeqHandles correctly in VFS1 /proc/net/.
Before this change:

```
$ docker run --runtime=runsc --rm -it -v ~/tmp:/hosttmp ubuntu:focal /hosttmp/issue5732 --bytes1=128 --bytes2=1024
#1: read(128) = 128
#2: read(1024) = EOF
$ docker run --runtime=runsc-vfs2 --rm -it -v ~/tmp:/hosttmp ubuntu:focal /hosttmp/issue5732 --bytes1=128 --bytes2=1024
#1: read(128) = 128
#2: read(1024) = 256
```

After this change:

```
$ docker run --runtime=runsc --rm -it -v ~/tmp:/hosttmp ubuntu:focal /hosttmp/issue5732 --bytes1=128 --bytes2=1024
#1: read(128) = 128
#2: read(1024) = 256
$ docker run --runtime=runsc-vfs2 --rm -it -v ~/tmp:/hosttmp ubuntu:focal /hosttmp/issue5732 --bytes1=128 --bytes2=1024
#1: read(128) = 128
#2: read(1024) = 256
```

Fixes #5732

PiperOrigin-RevId: 365178386
2021-03-25 20:27:38 -07:00
gVisor bot 8cece45a9d Merge release-20210315.0-27-g79bc446fa (automated) 2021-03-25 23:54:37 +00:00
Jamie Liu 79bc446fac Lock TaskSet mutex for writing in ptraceClone().
This is necessary since ptraceClone() mutates tracer.ptraceTracees.

PiperOrigin-RevId: 365152396
2021-03-25 16:50:06 -07:00
gVisor bot 2769d61f31 Merge release-20210315.0-26-g6b085ba47 (automated) 2021-03-25 19:05:27 +00:00
Kevin Krakauer 6b085ba477 setgid: skip tests when we can't find usable GIDs
PiperOrigin-RevId: 365092320
2021-03-25 12:00:24 -07:00
Howard Zhang 253f180c69 Fix comments error
Signed-off-by: Howard Zhang <howard.zhang@arm.com>
2021-03-25 17:39:45 +08:00
Howard Zhang a01fc7108f Fix nogo test error
Signed-off-by: Howard Zhang <howard.zhang@arm.com>
2021-03-25 17:39:28 +08:00
gVisor bot 71238fb956 Merge release-20210315.0-25-gc27fac421 (automated) 2021-03-25 01:05:55 +00:00